chore(factory): repin MCP Skills evidence to accepted core SEP - #2015
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Repository: groupthinking/EventRelay/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-authored-by: groupthinking <154503486+groupthinking@users.noreply.github.com>
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Pull request overview
Updates fixture-only MCP Skills import receipt provenance to treat the accepted core SEP as the normative contract, while preserving working-group spec artifacts as historical evidence.
Changes:
- Expand
wire_contractin generated receipts to includenormative_contract,design_history, andevidence_source_migration(while keepingspecification_commitaligned to the core SEP). - Update docs to reflect the “core SEP is source of truth” shift and preserve historical provenance links.
- Add a regression test ensuring the normative contract source is the core SEP (not archive/research sources).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| docs/mcp-skills-sep-2640-watch.md | Updates the watch note to treat the core SEP as normative while retaining ext-skills as historical evidence. |
| apps/web/src/lib/chatgpt-mcp-skill-import.ts | Splits wire contract provenance into explicit sources and emits them in receipts. |
| apps/web/src/lib/tests/chatgpt-mcp-skill-import.test.ts | Adds regression coverage to prevent emitting archive/research sources as “normative”. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| wire_contract: { | ||
| extension_id: MCP_SKILLS_EXTENSION_ID, | ||
| specification_commit: 'd866efdba298b55b8156c7b7aa1bdebc1b625f4c', | ||
| normative_contract: { | ||
| repository: 'modelcontextprotocol/modelcontextprotocol', | ||
| path: 'seps/2640-skills-extension.md', | ||
| commit: '1eb5bbe8ac933bdb595fedc687b8ed545e440491', | ||
| }, | ||
| design_history: { | ||
| repository: 'modelcontextprotocol/ext-skills', | ||
| path: 'specs/skills.md', | ||
| commit: 'd866efdba298b55b8156c7b7aa1bdebc1b625f4c', | ||
| }, | ||
| evidence_source_migration: { | ||
| repository: 'modelcontextprotocol/modelcontextprotocol', | ||
| path: 'seps/2640-skills-extension.md', | ||
| commit: 'f56f204f6290f6531b14d5734eb3e0a10f0eb201', | ||
| }, | ||
| }, |
| expect(receipt.wire_contract.normative_contract.repository).toBe( | ||
| 'modelcontextprotocol/modelcontextprotocol', | ||
| ); | ||
| expect(receipt.wire_contract.normative_contract.path).toBe('seps/2640-skills-extension.md'); | ||
| expect(receipt.wire_contract.normative_contract.commit).toBe( | ||
| '1eb5bbe8ac933bdb595fedc687b8ed545e440491', | ||
| ); |
| @@ -4,8 +4,21 @@ import { canonicalGateJson, hashCanonical } from '@/lib/gate-transition'; | |||
| export const MCP_SKILLS_EXTENSION_ID = 'io.modelcontextprotocol/skills' as const; | |||
| export const CHATGPT_SKILL_IMPORT_RECEIPT_VERSION = | |||
| 'eventrelay.chatgpt-mcp-skill-import-receipt.v1' as const; | |||
| export const MCP_SKILLS_NORMATIVE_CONTRACT = { | ||
| repository: 'modelcontextprotocol/modelcontextprotocol', | ||
| path: 'seps/2640-skills-extension.md', | ||
| commit: '1eb5bbe8ac933bdb595fedc687b8ed545e440491', | ||
| } as const; | ||
| export const MCP_SKILLS_DESIGN_HISTORY = { | ||
| repository: 'modelcontextprotocol/ext-skills', | ||
| path: 'specs/skills.md', | ||
| commit: 'd866efdba298b55b8156c7b7aa1bdebc1b625f4c', | ||
| } as const; | ||
| export const MCP_SKILLS_EVIDENCE_SOURCE_MIGRATION = { | ||
| repository: 'modelcontextprotocol/modelcontextprotocol', | ||
| path: 'seps/2640-skills-extension.md', | ||
| commit: 'f56f204f6290f6531b14d5734eb3e0a10f0eb201', |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Canonical issue
Outcome
Fixture-only MCP Skills receipts now point to the accepted core SEP as the normative contract, while preserving the older
ext-skillscommit as historical design evidence and recording the later link-repair migration. This keeps provenance accurate without changing runtime authority or claiming live client support.Scope
wire_contractinto explicit sources:normative_contract→modelcontextprotocol/modelcontextprotocol/seps/2640-skills-extension.md@1eb5bbe...design_history→modelcontextprotocol/ext-skills/specs/skills.md@d866efd...evidence_source_migration→modelcontextprotocol/modelcontextprotocol/...@f56f204...specification_commitaligned to the accepted core SEP commit for compatibility.Risk
wire_contractcould misread the richer receipt shape.Verification
List exact automated and manual checks, tied to the current head SHA.
Production evidence
Not applicable. This is a fixture-only provenance repair; no deploy, runtime activation, or external MCP skill execution path changed.
Agent handoff