Skip to content

chore(factory): repin MCP Skills evidence to accepted core SEP - #2015

Merged
groupthinking merged 3 commits into
mainfrom
copilot/chore-repin-mcp-skills-evidence
Sep 18, 2026
Merged

groupthinking merged 3 commits into
mainfrom
copilot/chore-repin-mcp-skills-evidence

Conversation

Copilot AI commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

Canonical issue

Outcome

Fixture-only MCP Skills receipts now point to the accepted core SEP as the normative contract, while preserving the older ext-skills commit as historical design evidence and recording the later link-repair migration. This keeps provenance accurate without changing runtime authority or claiming live client support.

Scope

  • Included:
    • Receipt provenance
      • Split wire_contract into explicit sources:
        • normative_contractmodelcontextprotocol/modelcontextprotocol/seps/2640-skills-extension.md@1eb5bbe...
        • design_historymodelcontextprotocol/ext-skills/specs/skills.md@d866efd...
        • evidence_source_migrationmodelcontextprotocol/modelcontextprotocol/...@f56f204...
      • Kept specification_commit aligned to the accepted core SEP commit for compatibility.
    • Regression coverage
      • Added a focused test that fails if a working-group/archive source is emitted as the normative specification.
    • Docs
      • Updated the SEP watch note to reflect the source-of-truth move into core MCP while preserving historical receipts.
  • Explicitly excluded:
    • Live ChatGPT import support
    • Any production activation or external skill execution
    • Broader parser/runtime changes outside the fixture receipt provenance

Risk

  • Risk level: low
  • Failure mode:
    • Consumers expecting only the legacy single-source interpretation of wire_contract could misread the richer receipt shape.
  • Rollback:
    • Revert the receipt field expansion and test/doc updates in this PR.

Verification

List exact automated and manual checks, tied to the current head SHA.

  • Focused tests
  • Required CI
  • Review threads resolved

Production evidence

Not applicable. This is a fixture-only provenance repair; no deploy, runtime activation, or external MCP skill execution path changed.

Agent handoff

  • One canonical issue is linked
  • No competing PR implements the same issue
  • Acceptance criteria are satisfied
  • Required checks pass on the current head
  • Human decision is requested only for product, security, irreversible infrastructure, or production approval
wire_contract: {
  extension_id: MCP_SKILLS_EXTENSION_ID,
  specification_commit: '1eb5bbe8ac933bdb595fedc687b8ed545e440491',
  normative_contract: {
    repository: 'modelcontextprotocol/modelcontextprotocol',
    path: 'seps/2640-skills-extension.md',
    commit: '1eb5bbe8ac933bdb595fedc687b8ed545e440491',
  },
  design_history: {
    repository: 'modelcontextprotocol/ext-skills',
    path: 'specs/skills.md',
    commit: 'd866efdba298b55b8156c7b7aa1bdebc1b625f4c',
  },
}

@coderabbitai

coderabbitai Bot commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: groupthinking/EventRelay/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 3bf7587c-126e-4b9c-8f1d-56082e59a0db

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Co-authored-by: groupthinking <154503486+groupthinking@users.noreply.github.com>
Copilot AI changed the title [WIP] Chore: Repin MCP skills evidence to accepted core SEP chore(factory): repin MCP Skills evidence to accepted core SEP Sep 18, 2026
Copilot AI requested a review from groupthinking September 18, 2026 20:53
@groupthinking
groupthinking marked this pull request as ready for review September 18, 2026 21:00
Copilot AI balanced review requested due to automatic review settings September 18, 2026 21:00
@groupthinking
groupthinking merged commit 04f0a64 into main Sep 18, 2026
@groupthinking
groupthinking deleted the copilot/chore-repin-mcp-skills-evidence branch September 18, 2026 21:00

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warning

Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.

Pull request overview

Updates fixture-only MCP Skills import receipt provenance to treat the accepted core SEP as the normative contract, while preserving working-group spec artifacts as historical evidence.

Changes:

  • Expand wire_contract in generated receipts to include normative_contract, design_history, and evidence_source_migration (while keeping specification_commit aligned to the core SEP).
  • Update docs to reflect the “core SEP is source of truth” shift and preserve historical provenance links.
  • Add a regression test ensuring the normative contract source is the core SEP (not archive/research sources).

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File Description
docs/mcp-skills-sep-2640-watch.md Updates the watch note to treat the core SEP as normative while retaining ext-skills as historical evidence.
apps/web/src/lib/chatgpt-mcp-skill-import.ts Splits wire contract provenance into explicit sources and emits them in receipts.
apps/web/src/lib/tests/chatgpt-mcp-skill-import.test.ts Adds regression coverage to prevent emitting archive/research sources as “normative”.

💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment on lines 91 to 108
wire_contract: {
extension_id: MCP_SKILLS_EXTENSION_ID,
specification_commit: 'd866efdba298b55b8156c7b7aa1bdebc1b625f4c',
normative_contract: {
repository: 'modelcontextprotocol/modelcontextprotocol',
path: 'seps/2640-skills-extension.md',
commit: '1eb5bbe8ac933bdb595fedc687b8ed545e440491',
},
design_history: {
repository: 'modelcontextprotocol/ext-skills',
path: 'specs/skills.md',
commit: 'd866efdba298b55b8156c7b7aa1bdebc1b625f4c',
},
evidence_source_migration: {
repository: 'modelcontextprotocol/modelcontextprotocol',
path: 'seps/2640-skills-extension.md',
commit: 'f56f204f6290f6531b14d5734eb3e0a10f0eb201',
},
},
Comment on lines +123 to +129
expect(receipt.wire_contract.normative_contract.repository).toBe(
'modelcontextprotocol/modelcontextprotocol',
);
expect(receipt.wire_contract.normative_contract.path).toBe('seps/2640-skills-extension.md');
expect(receipt.wire_contract.normative_contract.commit).toBe(
'1eb5bbe8ac933bdb595fedc687b8ed545e440491',
);
@@ -4,8 +4,21 @@ import { canonicalGateJson, hashCanonical } from '@/lib/gate-transition';
export const MCP_SKILLS_EXTENSION_ID = 'io.modelcontextprotocol/skills' as const;
export const CHATGPT_SKILL_IMPORT_RECEIPT_VERSION =
'eventrelay.chatgpt-mcp-skill-import-receipt.v1' as const;
Comment on lines +7 to +20
export const MCP_SKILLS_NORMATIVE_CONTRACT = {
repository: 'modelcontextprotocol/modelcontextprotocol',
path: 'seps/2640-skills-extension.md',
commit: '1eb5bbe8ac933bdb595fedc687b8ed545e440491',
} as const;
export const MCP_SKILLS_DESIGN_HISTORY = {
repository: 'modelcontextprotocol/ext-skills',
path: 'specs/skills.md',
commit: 'd866efdba298b55b8156c7b7aa1bdebc1b625f4c',
} as const;
export const MCP_SKILLS_EVIDENCE_SOURCE_MIGRATION = {
repository: 'modelcontextprotocol/modelcontextprotocol',
path: 'seps/2640-skills-extension.md',
commit: 'f56f204f6290f6531b14d5734eb3e0a10f0eb201',
@vercel

vercel Bot commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
v0-uvai Ready Ready Preview, v0 Sep 18, 2026 9:53pm UTC

@github-actions github-actions Bot added documentation Improvements or additions to documentation javascript Pull requests that update javascript code tests labels Sep 18, 2026

This branch was successfully deployed

1 active deployment
Preview ba350f61 Deployed Sep 18, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation javascript Pull requests that update javascript code tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore(factory): repin MCP Skills evidence to accepted core SEP

3 participants