-
Notifications
You must be signed in to change notification settings - Fork 4k
Adds Grpc.newManagedChannel(String, ChannelCredentials, NameResolverR… #11901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
043b468
5e1b7b3
49f8dc4
a88e430
4288b51
0e436bb
e65d7ca
dd007ec
f3f49b6
3859ae5
7fc22d7
73c94c2
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -65,7 +65,7 @@ public abstract class NameResolverProvider extends NameResolver.Factory { | |
| * | ||
| * @since 1.40.0 | ||
| * */ | ||
| protected String getScheme() { | ||
| public String getScheme() { | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The review was held up to see if this change would cause problems. It potentially could, but I suspect all implementations of NameResolverProvider today are not implementing getScheme() and instead just implementing getDefaultScheme(). Not even delegating NRPs like SecretGrpclbNameResolverProvider and GoogleCloudToProdNameResolverProvider have getScheme() implemented. (Nor are there any implementations of getScheme() inside google3.) So this is a better time to make it public. |
||
| return getDefaultScheme(); | ||
| } | ||
|
|
||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.