xds: Propagate status cause through XdsDepManager#12749
Open
ejona86 wants to merge 1 commit intogrpc:masterfrom
Open
xds: Propagate status cause through XdsDepManager#12749ejona86 wants to merge 1 commit intogrpc:masterfrom
ejona86 wants to merge 1 commit intogrpc:masterfrom
Conversation
Often there is no cause, but connect(), channel credentials, and call credentials failures on the control plane RPC can include a useful causal exception. This was triggered by seeing an error like below, but it didn't include the cause, which would have included HTTP error information from the failure fetching the credential. ``` UNAVAILABLE: Error retrieving LDS resource xdstp://traffic-director-c2p.xds.googleapis.com/envoy.config.listener.v3.Listener/bigtable.googleapis.com: UNAUTHENTICATED: Failed computing credential metadata nodeID: C2P-798500073 ```
shivaspeaks
approved these changes
Apr 13, 2026
| /** | ||
| * An interceptor that fails all RPCs with the provided status. | ||
| */ | ||
| final class FailingClientInterceptor implements ClientInterceptor { |
Member
There was a problem hiding this comment.
I want to understand here how do you take a decision on when to create a new class and when we should not. I always remember your comment here: #11638 (comment). It doesn't look like this class is getting used anywhere and this is in test anyway, so this utility class shouldn't we be nesting it within the user class?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Often there is no cause, but connect(), channel credentials, and call credentials failures on the control plane RPC can include a useful causal exception.
This was triggered by seeing an error like below, but it didn't include the cause, which would have included HTTP error information from the failure fetching the credential.