core: Gracefully handle GOAWAY frames with unrecognized error codes (v1.82.x backport) - #13045
Open
AgraVator wants to merge 1 commit into
Open
core: Gracefully handle GOAWAY frames with unrecognized error codes (v1.82.x backport)#13045AgraVator wants to merge 1 commit into
AgraVator wants to merge 1 commit into
Conversation
kannanjgithub
approved these changes
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #13035 to v1.82.x.
Fixes #13031.
Discussion: #13026.
When a server or reverse proxy sends an HTTP/2
GOAWAYframe containing an unrecognized or non-standard error code (e.g., Apache HTTP Server 2.4.62'sAPR_TIMEUP 70007 / AH03069),GrpcUtil.Http2Error.forCode(errorCode)returnsnull.On
master,GoAwayDisconnectErrorthrew an uncaughtNullPointerExceptionwhen passed anullHttp2Error:Changes
GoAwayDisconnectError, defaultnullerror code toGrpcUtil.Http2Error.INTERNAL_ERRORrather than throwingNullPointerException.GrpcUtilTestcoveringGoAwayDisconnectErrornull and unknown error code fallbacks.NettyClientHandlerTestverifying that unknown GOAWAY error codes cleanly shut down the transport, cancel active streams, and fail new streams withUNAVAILABLErather than hanging.