You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The storage namespace used for Bluetooth bonding data can now be selected. It defaults to nimble_bond; names longer than the supported limit fall back to the default.
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.
📝 Walkthrough
Arr, the NVS store now supports selecting a namespace, with nimble_bond as the default. Diagnostics use LOG_TAG; existing storage behavior and error returns remain unchanged.
Changes: NVS store updates
Layer / File(s)
Summary
Namespace selection and NVS diagnostics src/nimble/nimble/host/store/config/src/ble_store_nvs.c
Arr, set_nimble_nvs_namespace selects the default for NULL or names with 16 or more characters. It copies shorter names for NVS use. Diagnostics now use LOG_TAG, while existing error handling remains unchanged.
The change enables selecting an NVS namespace before initialization and preserves the diagnostic tag value. No concrete user-facing or operational regression is established, so the PR is ready to merge subject to normal checks.
Pre-merge checks: 4 · 1
Failed checks: 1 warning
Check name
Status
Explanation
Resolution
Docstring Coverage
Docstring coverage is 28.57% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 21 functions across 1 files.
Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed checks: 4 passed
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title describes the real logging change from TAG to LOG_TAG, but the pull request also adds configurable NVS namespace behavior. The title is partially related to the changeset and remains specifi…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Title check
Explanation
The title describes the real logging change from TAG to LOG_TAG, but the pull request also adds configurable NVS namespace behavior. The title is partially related to the changeset and remains specific enough to pass, arrr.
Fix all pre-merge checks with AI
✨ Finishing Touches: 💡 1
📝 Generate docstrings: 💡
Commit to this branch
Create a new PR
🧪 Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Arr, a namespace joins the store, nimble_bond waits at shore. Short names sail, long names turn, LOG_TAG marks each message stern. The stored records keep their course, While error paths retain their force.
Comment @coderabbitai help to get the list of available commands.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
nimble_bond; names longer than the supported limit fall back to the default.