Skip to content

Revert nvs log tag change. - #1198

Merged
h2zero merged 1 commit into
masterfrom
fix-nvs-logs
Oct 18, 2026
Merged

h2zero merged 1 commit into
masterfrom
fix-nvs-logs

Conversation

@h2zero

@h2zero h2zero commented Oct 18, 2026 •

Copy link
Copy Markdown
Owner

Summary by CodeRabbit

  • New Features
    • The storage namespace used for Bluetooth bonding data can now be selected. It defaults to nimble_bond; names longer than the supported limit fall back to the default.

@coderabbitai

coderabbitai Bot commented Oct 18, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 114835f1-6fd6-450e-afe4-4e1967880038
📥 Commits

Reviewing files that changed from the base of the PR and between e5b2ab4 and 895c6fd.

📒 Files selected for processing: 1
  • src/nimble/nimble/host/store/config/src/ble_store_nvs.c

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.

📝 Walkthrough

Arr, the NVS store now supports selecting a namespace, with nimble_bond as the default. Diagnostics use LOG_TAG; existing storage behavior and error returns remain unchanged.

Changes: NVS store updates

Layer / File(s) Summary
Namespace selection and NVS diagnostics
src/nimble/nimble/host/store/config/src/ble_store_nvs.c
Arr, set_nimble_nvs_namespace selects the default for NULL or names with 16 or more characters. It copies shorter names for NVS use. Diagnostics now use LOG_TAG, while existing error handling remains unchanged.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Feature

Suggested reviewers: r3wretrhy

Merge Risk: ⚪ Minimal · up to 895c6

The change enables selecting an NVS namespace before initialization and preserves the diagnostic tag value. No concrete user-facing or operational regression is established, so the PR is ready to merge subject to normal checks.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 28.57% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 21 functions across 1 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks: 4 passed
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title describes the real logging change from TAG to LOG_TAG, but the pull request also adds configurable NVS namespace behavior. The title is partially related to the changeset and remains specifi…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title describes the real logging change from TAG to LOG_TAG, but the pull request also adds configurable NVS namespace behavior. The title is partially related to the changeset and remains specific enough to pass, arrr.

  • Fix all pre-merge checks with AI
✨ Finishing Touches: 💡 1
📝 Generate docstrings: 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Arr, a namespace joins the store,
nimble_bond waits at shore.
Short names sail, long names turn,
LOG_TAG marks each message stern.
The stored records keep their course,
While error paths retain their force.

Comment @coderabbitai help to get the list of available commands.

@h2zero
h2zero merged commit 1fa2fc5 into master Oct 18, 2026
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant