Follow HLint suggestion: use <$> - #12015
Open
philderbeast wants to merge 28 commits into
Open
Conversation
philderbeast
marked this pull request as draft
June 24, 2026 01:47
philderbeast
force-pushed
the
hlint/use-fmap-operator
branch
6 times, most recently
from
June 24, 2026 02:22
032d9c5 to
c0f2629
Compare
philderbeast
marked this pull request as ready for review
June 24, 2026 02:22
philderbeast
force-pushed
the
hlint/use-fmap-operator
branch
from
June 26, 2026 00:13
c0f2629 to
d6f48d1
Compare
philderbeast
force-pushed
the
hlint/use-fmap-operator
branch
from
July 1, 2026 18:35
d6f48d1 to
388296c
Compare
Bodigrim
reviewed
Jul 5, 2026
Bodigrim
reviewed
Jul 5, 2026
Bodigrim
reviewed
Jul 5, 2026
Bodigrim
reviewed
Jul 5, 2026
Bodigrim
reviewed
Jul 5, 2026
Bodigrim
reviewed
Jul 5, 2026
Bodigrim
reviewed
Jul 5, 2026
Bodigrim
reviewed
Jul 5, 2026
philderbeast
force-pushed
the
hlint/use-fmap-operator
branch
from
July 5, 2026 12:28
1834ec6 to
91914a5
Compare
philderbeast
force-pushed
the
hlint/use-fmap-operator
branch
from
July 23, 2026 18:29
e241b16 to
2a34fc8
Compare
Co-Authored-By: ˌbodʲɪˈɡrʲim <andrew.lelechenko@gmail.com>
philderbeast
force-pushed
the
hlint/use-fmap-operator
branch
from
July 23, 2026 19:38
580079b to
37f6728
Compare
Bodigrim
reviewed
Jul 26, 2026
| runShrinker $ | ||
| pure SourceRepositoryPackage | ||
| <*> shrinker srpType | ||
| (SourceRepositoryPackage <$> shrinker srpType) |
Collaborator
There was a problem hiding this comment.
Is the bracket required?
Bodigrim
reviewed
Jul 26, 2026
| s <- parsec | ||
| exc <- exception | ||
| return $ ELicense s exc | ||
| ELicense s <$> exception |
Collaborator
There was a problem hiding this comment.
If we are in the business of rewriting monadic parsers in applicative style, let's not stop halfway through. Could we define simple = ELicense <$> parsec <$> exception?
Bodigrim
reviewed
Jul 26, 2026
| P.spaces | ||
| t <- term | ||
| return (intersectVersionRanges f t) | ||
| intersectVersionRanges f <$> term |
Collaborator
There was a problem hiding this comment.
Same as above, it feels confusing to switch from monadic parser style to applicative in the middle of do-block. We can rewrite this in its entirety as an applicative expression.
| _ <- P.char '=' | ||
| abi <- parsec | ||
| return (AbiDependency uid abi) | ||
| AbiDependency uid <$> parsec |
Collaborator
There was a problem hiding this comment.
parsec = AbiDependency <$> parsec <* P.char '=' <*> parsec.
| _ <- P.char ':' | ||
| mod_name <- parsec | ||
| return (Module uid mod_name) | ||
| Module uid <$> parsec |
Collaborator
There was a problem hiding this comment.
Same as above, let's rewrite the entire do-block in applicative style.
| a <- getWord64le | ||
| b <- getWord64le | ||
| return (Fingerprint a b) | ||
| Fingerprint a <$> getWord64le |
Collaborator
There was a problem hiding this comment.
Same, binaryGetMD5 = Fingerprint <$> getWord64le <*> getWord64le
| _ <- P.char '-' | ||
| os <- parsec | ||
| return (Platform arch os) | ||
| Platform arch <$> parsec |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #9110. Discharges and no longer ignores HLint's "use <$>" suggestion so that this will be suggested by our CI linting.
A similar suggestion, "use fmap", was merged earlier, with #11742.
There were some cascading suggestions that I tackled individually. I'll squash commits before applying the merge label if this pull request is approved.