Fix --keep-temp-files given to Cabal lib versions that don't have it. - #12184
Open
nh2 wants to merge 1 commit into
Open
Fix --keep-temp-files given to Cabal lib versions that don't have it.#12184nh2 wants to merge 1 commit into
--keep-temp-files given to Cabal lib versions that don't have it.#12184nh2 wants to merge 1 commit into
Conversation
`Cabal < 3.13` did not support this flag
(it did for `... haddock` but not `... repl`).
So `Setup.hs` compiled with such older versions rejects it.
This causes errors for users of `haskell-language-server` if
they have a custom `Setup.hs` depending on `Cabal < 3.13`,
because it makes `hie-bios` pass the nonexistent flag,
causing error:
unrecognized 'repl' option `--keep-temp-files'
Error: [Cabal-7125]
repl failed for my-package-0.1.0.0.
`filterCommonFlags` already removes the flag for `lib:Cabal < 3.13`.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #10292 (review)
Template Α: This PR modifies behaviour or interface
Include the following checklist in your PR:
significance: significantin the changelog file.CC @9999years