Skip to content

fix(studio): preserve zero caption scale#2545

Open
tianma-if wants to merge 1 commit into
heygen-com:mainfrom
tianma-if:codex/caption-zero-scale
Open

fix(studio): preserve zero caption scale#2545
tianma-if wants to merge 1 commit into
heygen-com:mainfrom
tianma-if:codex/caption-zero-scale

Conversation

@tianma-if

Copy link
Copy Markdown

Summary

  • preserve valid zero-valued GSAP caption transforms
  • share finite-number fallback handling between the overlay and property panel
  • add regression coverage for zero scale and non-finite values

Why

Both caption editing paths used value || 1 for scale. A caption intentionally animated to scale zero was therefore read back as scale one, causing editor interactions to make it visible again.

Validation

  • bunx oxfmt and bunx oxlint on changed files
  • bun run --filter @hyperframes/studio test -- CaptionOverlayUtils.test.ts
  • bun run --filter @hyperframes/studio typecheck

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant