fix(studio): keep composition multi-drag positions in sync#2629
Merged
Conversation
miguel-heygen
added a commit
that referenced
this pull request
Jul 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Dragging multiple composition tracks now keeps their new positions immediately instead of snapping back until Studio is refreshed.
Why
The drag already persisted the correct timing to
index.html, but the live DOM patch resolved a top-level composition host against its child composition file. Because the host was not updated in the preview, a delayed runtime manifest restored its stale start time in Studio state.How
Top-level composition tracks now use the existing composition-aware timeline lookup when patching preview timing. Normal timeline elements keep the existing generic selection lookup, limiting the behavior change to composition hosts. A regression test covers patching a composition host in its parent source file.
Test plan
Unit tests added/updated
Manual testing performed
Documentation updated (not applicable — no documentation behavior changed)
bun run --filter @hyperframes/studio test -- src/hooks/timelineEditingHelpers.test.ts src/components/editor/domEditing.test.ts(61 tests passed)bun run --filter @hyperframes/studio typecheckIn Studio on port 5190, marquee-selected three composition tracks, dragged them together, and confirmed their positions remained stable after runtime synchronization