Update TypeScript to v6 and bump dev dependencies#1856
Conversation
Update developer tooling versions and adjust contributor documentation. Dependencies such as eslint, prettier, rollup, TypeScript, @typescript-eslint packages and @types/node were bumped in package.json and the lockfile was regenerated. AGENTS.md: removed the hard-coded "TypeScript v5.4.5" reference (now just "TypeScript") and deleted an outdated frontmatter note about newly added rule pages.
Deploying htmlhint with
|
| Latest commit: |
b40fbe0
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://70bae3b4.htmlhint.pages.dev |
| Branch Preview URL: | https://dev-coliff-typescript-6-upda.htmlhint.pages.dev |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates documentation in AGENTS.md by removing specific version references and redundant instructions, and upgrades several dev dependencies in package.json. However, the review feedback indicates that several of the specified versions—including TypeScript 6.0.3, ESLint 10.2.1, and Prettier 3.8.3—do not exist in the public npm registry, which will cause installation failures and poses a security risk. Additionally, the reviewer noted an inconsistent versioning strategy where some dependencies are pinned while others now use caret ranges, recommending a uniform approach for maintainability.
| "rollup": "4.59.1", | ||
| "typescript": "5.9.3" | ||
| "rollup": "4.60.2", | ||
| "typescript": "^6.0.3" |
There was a problem hiding this comment.
The version ^6.0.3 for typescript is invalid as this version does not exist in the public npm registry (the current stable version is 5.x). Furthermore, using a caret range (^) allows for versions >= 6.1.0, which will conflict with the peer dependency constraints of the updated @typescript-eslint packages (which require typescript: <6.1.0). Similar non-existent versions are specified for eslint (10.2.1), prettier (3.8.3), rollup (4.60.2), and @types/node (20.19.39). This poses a critical security risk (dependency confusion) and will cause installation failures.
| "@typescript-eslint/eslint-plugin": "^8.58.2", | ||
| "@typescript-eslint/parser": "^8.58.2", |
There was a problem hiding this comment.
The versioning strategy for dev dependencies has become inconsistent in this PR. While packages like prettier and rollup remain pinned to exact versions, @typescript-eslint packages have been changed from pinned versions to caret ranges (^). It is recommended to maintain a consistent strategy across all developer tooling, preferably pinning versions to ensure reproducible builds and avoid unexpected breaking changes during installation.
References
- Maintain consistent versioning strategies for dependencies within the same block. (link)
coliff
changed the title
There was a problem hiding this comment.
Pull request overview
Updates the repository’s developer tooling dependencies (linting/formatting/build/TS) and refreshes contributor guidance in AGENTS.md to remove outdated version-specific or formatting notes.
Changes:
- Bumped dev tooling versions in
package.json(ESLint, Prettier, Rollup, TypeScript,@typescript-eslint/*, and@types/node). - Regenerated
package-lock.jsonto reflect the updated dependency graph. - Simplified/updated
AGENTS.md(removed hard-coded TypeScript version reference and an outdated website rule-page note).
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| package.json | Updates dev dependency versions, including moving TypeScript to ^6.0.3. |
| package-lock.json | Regenerated lockfile reflecting updated versions and transitive deps. |
| AGENTS.md | Removes outdated guidance; still contains a frontmatter example that appears inconsistent with current website docs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - Use the provided code snippets as examples for rule documentation. | ||
| - Newly added rules pages for the website should have the frontmatter: sidebar: hidden: true badge: New | ||
| - Always run `npm run build` before running tests or committing changes. | ||
| - When adding a new rule to website ensure that it has the frontmatter: `pagefind: false sidebar: badge: New hidden: true`. |
| "rollup": "4.59.1", | ||
| "typescript": "5.9.3" | ||
| "rollup": "4.60.2", | ||
| "typescript": "^6.0.3" |
Update developer tooling versions and adjust contributor documentation. Dependencies such as eslint, prettier, rollup, TypeScript, @typescript-eslint packages and @types/node were bumped in package.json and the lockfile was regenerated. AGENTS.md: removed the hard-coded "TypeScript v5.4.5" reference (now just "TypeScript") and deleted an outdated frontmatter note about newly added rule pages.