Set incoming requesting timeout#1154
Closed
phillipj wants to merge 1 commit into
Closed
Conversation
This ensures the incoming request does not timeout before the target's timeout configured with `options.proxyTimeout` Fixes http-party#1113
Author
|
Looking at the test that fails with these changes added, I wonder if that test is wrong. It doesn't expect the client request being made to throw an error if an error occurs. At first glance that seems weird, cause a timeout is also an error to the client initiating the request, right? Additionally there is two very similar tests, whereas the latter succeeds cause it expects timeouts to raise client error: |
Member
|
Closing as a duplicate of #1273 – if it's not a strict duplicate . from a software design perspective this belongs in the |
Member
|
Thanks for helping triage this issue and contribute a proposed fix though 😸 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ensures the incoming request does not timeout before the target's timeout configured with
options.proxyTimeout.As I'm not familiar to the code base, I struggled seeing the best entry to write a test for this. Any thoughts would be appreciated.
Fixes #1113
Edit: I'm looking into the existing timeout test failing