Skip to content

Add follow-redirects options support#1533

Open
pachirel wants to merge 2 commits into
http-party:masterfrom
pachirel:add-follow-redirects-options-support
Open

Add follow-redirects options support#1533
pachirel wants to merge 2 commits into
http-party:masterfrom
pachirel:add-follow-redirects-options-support

Conversation

@pachirel

Copy link
Copy Markdown
Contributor

I saw issue #1412 and PR #1441.
I'd like to support all follow-redirects options, I created another PR to support it.

I respect the attribute format of #1441.

Notes:

  • I found it's required to update DefinitelyTyped. Because followRedirects option is declared as boolean.
  • I haven't checked which follow-redirects versions support these options. I tested 1.9.0 (defined in package-lock.json) and 1.14.1. Please check your follow-redirects version.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #1533 (f7f3c6a) into master (9b96cd7) will increase coverage by 0.14%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1533      +/-   ##
==========================================
+ Coverage   92.38%   92.52%   +0.14%     
==========================================
  Files           6        6              
  Lines         315      321       +6     
==========================================
+ Hits          291      297       +6     
  Misses         24       24              
Impacted Files Coverage Δ
lib/http-proxy/common.js 97.29% <100.00%> (+0.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b96cd7...f7f3c6a. Read the comment docs.

@pachirel pachirel marked this pull request as draft June 9, 2021 11:04
@pachirel pachirel marked this pull request as ready for review June 9, 2021 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants