Fix: Ensure Content-Type: application/json is set when JSON data is sent with custom headers - #1910
Closed
vinayK34 wants to merge 2 commits into
Closed
Fix: Ensure Content-Type: application/json is set when JSON data is sent with custom headers#1910vinayK34 wants to merge 2 commits into
vinayK34 wants to merge 2 commits into
Conversation
…ent with custom headers The issue was in the `apply_missing_repeated_headers` function in `httpie/client.py`. When sending a POST request with JSON data and a single custom header, the automatic Content-Type: application/json header was not being preserved properly due to incorrect header merging logic. This fix preserves the automatic Content-Type header for JSON data even when there's only one custom header present, ensuring consistent behavior regardless of the number of custom headers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where the
Content-Type: application/jsonheader was not being set properly when sending POST requests with JSON data and a single custom header.Root Cause:
The issue was in the
apply_missing_repeated_headersfunction inhttpie/client.py. When there's only one custom header, the header merging logic incorrectly interfered with the automatic setting of theContent-Type: application/jsonheader that should be applied when JSON data is sent.Fix:
Modified the
apply_missing_repeated_headersfunction to detect when Content-Type was automatically set for JSON data and preserve it during header processing, regardless of the number of custom headers present.Testing: