fix: correct Windows guard in is_available() - #1911
Open
cyforkk wants to merge 1 commit into
Open
Conversation
The previous check compared a built-in function object to a string, which is always False. The Windows short-circuit never fired, causing the function to rely on a swallowed exception for control flow on Windows. This fix uses for a robust Windows check. Fixes httpie#1898
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The previous check
os.system == 'nt'compared a built-in function object to a string, which is alwaysFalse. The Windows short-circuit never fired, causing the function to rely on a swallowed exception for control flow on Windows.This fix uses
sys.platform == 'win32'for a robust Windows check.Changes
is_available()inhttpie/output/ui/man_pages.pyto usesys.platform == 'win32'import systests/test_man_pages.pycovering:Fixes #1898