Fix AdaLayerNormZeroSingle.forward return type annotation#13543
Open
Ricardo-M-L wants to merge 1 commit intohuggingface:mainfrom
Open
Fix AdaLayerNormZeroSingle.forward return type annotation#13543Ricardo-M-L wants to merge 1 commit intohuggingface:mainfrom
Ricardo-M-L wants to merge 1 commit intohuggingface:mainfrom
Conversation
The return type was annotated as a 5-element tuple (copied from AdaLayerNormZero), but the method actually returns 2 elements (x, gate_msa). All callers correctly unpack 2 elements.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
AdaLayerNormZeroSingle.forward()has a return type annotation declaring a 5-element tuple:The 5-element annotation was copied from
AdaLayerNormZero.forward()which does return 5 elements (x, gate_msa, shift_mlp, scale_mlp, gate_mlp), but the "Single" variant only returns 2 (x, gate_msa).All callers correctly unpack 2 elements (e.g.,
norm_hidden_states, gate = self.norm(hidden_states, emb=temb)in FluxSingleTransformerBlock), so this is just a type annotation fix.Before submitting
Who can review?
@yiyixuxu @sayakpaul