Replace bare except with except Exception#13550
Closed
Ricardo-M-L wants to merge 1 commit intohuggingface:mainfrom
Closed
Replace bare except with except Exception#13550Ricardo-M-L wants to merge 1 commit intohuggingface:mainfrom
Ricardo-M-L wants to merge 1 commit intohuggingface:mainfrom
Conversation
Bare `except:` clauses catch `SystemExit` and `KeyboardInterrupt`, preventing graceful shutdown and making the process uninterruptible. Replace with `except Exception:` which preserves the original error-handling behavior while allowing system-exiting exceptions to propagate. Affected locations: - utils/hub_utils.py:301 — fallback download path - experimental/rl/value_guided_sampling.py:60,66 — dataset stat computation Signed-off-by: Ricardo-M-L <Sibyl_Hartmanbnb@webname.com>
Contributor
Author
|
Closing this in favor of the substantive bug fixes I have open in the queue. The bare |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Replaces 3 bare
except:clauses withexcept Exception:.Bare
except:catchesSystemExitandKeyboardInterrupt, which prevents graceful shutdown (e.g.Ctrl+Cduring a download inhub_utils.pywould be silently swallowed instead of interrupting the process).except Exception:preserves the original error-handling behavior while allowing system-exiting exceptions to propagate normally.Locations
utils/hub_utils.pyexperimental/rl/value_guided_sampling.pyexperimental/rl/value_guided_sampling.pyWho can review?
Anyone in the community is free to review the PR. @yiyixuxu @sayakpaul