fix(mag_cache): correct per-transformer step count for dual-transformer pipelines#14027
Open
lcheng321 wants to merge 1 commit into
Open
fix(mag_cache): correct per-transformer step count for dual-transformer pipelines#14027lcheng321 wants to merge 1 commit into
lcheng321 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14025
Root Cause
MagCacheConfigis applied to both transformers withnum_inference_stepsequal to the full pipeline step count. In dual-transformer pipelines (Wan 2.2),transformerruns only the high-noise stage andtransformer_2only the low-noise stage. Each executes a subset of the total steps, never the full count.Three consequences:
_advance_step:state.step_index >= config.num_inference_stepsnever fires, so state never resets and calibration output is never printed.int(retention_ratio * num_inference_steps)is computed against the full step count, protecting more actual steps from skipping than intended.mag_ratiosindexing:step_indexno longer maps to the correct denoising timestep.Changes
src/diffusers/hooks/mag_cache.py_original_mag_ratiosbefore interpolation so ratios can be re-interpolated to the corrected count._mag_cache_configon the module afterapply_mag_cacheso pipelines can reach it.update_mag_cache_num_stepshelper.src/diffusers/pipelines/wan/pipeline_wan.py,pipeline_wan_i2v.py,pipeline_wan_vace.pyAfter
boundary_timestepis computed, count actual steps per transformer and correct each config before the denoising loop. No-op when MagCache is not applied.