Repository navigation
chore: prepare the initial CRAN submission of 0.2.0 - #4
Open
billdenney wants to merge 11 commits into
Open
billdenney wants to merge 11 commits into
billdenney wants to merge 11 commits into
Conversation
The maintainer email address pointed at a domain that does not exist (humanpred.com); CRAN's confirmation email would never have arrived. The copyright holders of the bundled files are now stated: the Define-XML schema files are CDISC's (MIT License, from the cdisc-org GitHub repositories) and the stylesheets are Lex Jansen's (MIT License, per their headers). The README and data-raw comments had called both Apache-licensed. inst/COPYRIGHTS lists every bundled file with its source and license, and NCI EVS is credited as the data contributor for the public-domain CT. Also: Language field and inst/WORDLIST so the spell check is clean, .Rbuildignore for the .git file a worktree leaves at the package root, and cran-comments.md rewritten for this submission. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
The CT tables are plain data frames, so auto-printing a 125k-row result in the get_ct() and get_dataset() examples took over ten seconds under R CMD check and raised the example-timing NOTE. The examples now assign the result and show head() and nrow(). Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
Brings the CDISC Library implementation-guide, model, CDASH, and QRS tables and the inst/COPYRIGHTS update from main into the CRAN release. Conflicts were resolved as: - DESCRIPTION: the release's version (0.2.0), maintainer email, and Authors@R (with the copyright holders); main's Description text. - R/get_dataset.R: the release's examples that print only the head or the row count, plus main's ig_adam example in the same style; the Rd file regenerated with roxygen2 8.1.0. - README.md: main's provenance rows for the CDISC Library tables, with the release's MIT (CDISC) license for the Define-XML 2.1 schema, as inst/COPYRIGHTS and Authors@R state. - inst/COPYRIGHTS: main's, which adds the entry for the new tables to the release's. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The version stays 0.2.0 for the resubmission, so the changes merged from main's development version are part of 0.2.0: their heading becomes the 0.2.0 heading, with the CRAN release preparation notes first. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ndards CRAN asked that every acronym in the Description be explained. CDISC, CT, SDTM, ADaM, SDTMIG, SENDIG, ADaMIG, CDASH, QRS, XML, XSD, and XSLT are now spelled out where they first appear, and the Description links the CDISC standards page and the pharmaverse site in angle brackets. There are no method references to cite: the package holds reference data and accessor functions, not methods. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
CRAN asked that functions, examples, and vignettes not install packages. None of them does; the one install was in tests/testthat/test-attach.R, which built the package with pkgbuild and installed it into a temporary library when the tests ran from a source tree. The test now runs only against an installed copy, which under R CMD check is the build under test, and skips from a source tree instead of installing. pkgbuild, used only there, leaves Suggests. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ig_sdtm and ig_adam are now built from the CDISC Library exports, as the entry merged from main says, so the earlier entry describing them as transcribed from the published specification documents no longer holds. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The package's language is en-US: "normalised" and "licence" in the text merged from main become "normalized" and "license". The CDISC terms that main's new tables and NEWS added (CDASH, CDASHIG, QRS, SENDIG, and the ADaM, SENDIG, and QRS supplement names among them) join inst/WORDLIST, so spelling::spell_check_package() is clean. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A fresh cran-comments.md for the resubmission answers each comment of the review: every acronym of the Description is explained, the package has no method reference to cite and links the CDISC standards instead, and no function, example, or vignette installs a package (the one test that did no longer does). NEWS.md records the resubmission changes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The copyright holders of the bundled files are now stated: the Define-XML
schema files are CDISC's (MIT License, from the cdisc-org GitHub
repositories) and the stylesheets are Lex Jansen's (MIT License, per their
headers). The README and data-raw comments had called both Apache-licensed.
inst/COPYRIGHTS lists every bundled file with its source and license, and
NCI EVS is credited as the data contributor for the public-domain CT.
Also: Language field and inst/WORDLIST so the spell check is clean,
.Rbuildignore for the .git file a worktree leaves at the package root, and
cran-comments.md rewritten for this submission.
Co-Authored-By: Claude Fable 5.1 noreply@anthropic.com