Fix unused sandbox test import on ARM64 - #1812
Open
simongdavies wants to merge 1 commit into
Open
Conversation
MultiUseSandbox is used by x86-64 tests and trace_guest helpers. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Simon Davies <simongdavies@users.noreply.github.com>
simongdavies
requested review from
andreiltd,
danbugs,
dblnz,
devigned,
jprendes,
jsturtevant,
ludfjig,
squillace and
syntactically
as code owners
September 9, 2026 09:39
simongdavies
added
area/testing
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The import gating matches all verified MultiUseSandbox references in this test module (x86_64-only tests and trace_guest-only helpers), so it should eliminate the ARM64 warning without affecting compilation.
Pull request overview
This PR adjusts the test-module imports in hyperlight_host so MultiUseSandbox is only imported in configurations where it is actually referenced, avoiding an unused-import warning in default ARM64 (aarch64) builds.
Changes:
- Gate the
use crate::MultiUseSandbox;test import behindcfg(any(target_arch = "x86_64", feature = "trace_guest")). - Remove
MultiUseSandboxfrom the unconditional groupeduse crate::{ ... }list in the test module.
File summaries
| File | Description |
|---|---|
| src/hyperlight_host/src/sandbox/initialized_multi_use.rs | Gates the test import of MultiUseSandbox to match the cfg conditions of its uses, preventing ARM64 unused-import warnings. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
ludfjig
approved these changes
Sep 9, 2026
ludfjig
left a comment
ludfjig
left a comment
Contributor
There was a problem hiding this comment.
lgtm but why didn't ci fail?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Gate the
MultiUseSandboxtest import withcfg(any(target_arch = "x86_64", feature = "trace_guest")). Its uses are limited to those configurations. This prevents an unused-import warning in default ARM64 builds.