Fix GH-20863: read HEIC/HEIF dimensions for grid and Exif-only images#135
Closed
iliaal wants to merge 1 commit into
Closed
Fix GH-20863: read HEIC/HEIF dimensions for grid and Exif-only images#135iliaal wants to merge 1 commit into
iliaal wants to merge 1 commit into
Conversation
Camera HEIC files are grid images whose primary item holds the full-size ispe, but libavifinfo dropped that association once tile items filled its 32-entry ipma table, so the dimensions never resolved. Reserve ipma slots for the primary item so its association survives. Some files also omit any bit-depth property, so libavifinfo reports nothing even with a valid ispe; for those, fall back to the dimensions in the embedded Exif item. Fixes phpGH-20863
Owner
Author
|
Promoted upstream as php#22491. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getimagesize() returns false for most camera-produced HEIC files. They are grid images whose primary item carries the full-size ispe, but libavifinfo drops that association once the tile items fill its 32-entry ipma table, so the dimensions never resolve. This reserves a few ipma slots for the primary item so its association survives. Some HEIC files also expose no bit-depth property, so libavifinfo declines to report even with a valid ispe; for those the dimensions come from the embedded Exif item (ImageWidth/ImageLength, or PixelXDimension/PixelYDimension in the Exif sub-IFD). The avifinfo.c change touches vendored upstream code and should also go upstream.
Fixes php#20863