[SYCL] Prepare some deprecated aliases for removal#22371
Draft
KornevNikita wants to merge 3 commits into
Draft
Conversation
These aliases have been removed in SYCL 2020. Prepare them to be removed in the next ABI-breaking window.
KornevNikita
commented
Jun 26, 2026
| #define __SYCL_MAKE_VECTOR_ALIAS(ALIAS, TYPE, N) \ | ||
| using ALIAS##N = sycl::vec<TYPE, N>; | ||
|
|
||
| #ifndef __INTEL_PREVIEW_BREAKING_CHANGES |
Contributor
Author
There was a problem hiding this comment.
@gmlueck hi, could you please review the changes in this file?
I'd like to remove deprecated aliases that are not part of SYCL 2020:
I have no doubts regarding sycl::cl_* as these aliases have been replaced by sycl::opencl::cl_*.
But the rest (see PR desc) has been removed without any replacement. Although this change aligns our implementation with the spec, I'm not sure if it's desired.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch prepares deprecated aliases to be removed in the next ABI-breaking window (they're not a part of SYCL 2020):