[sycl-jit] Centralize warning flags in sycl_jit#22410
Open
lslusarczyk wants to merge 1 commit into
Open
Conversation
…flags Define sycl-jit compile warnings in one helper (optional -Werror via genex, host GCC -Wno-error=conversion on LLVM/Clang headers) and use it for sycl-jit, SYCLJITPasses, and SYCLJITPassesPlugin.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SYCLJITPasses/SYCLJITPassesPluginfailing on-Werror=conversionwhen compiling against LLVM headers (e.g.SYCLSpecConstMaterializer.cpp), same class of issue as #21933 for thesycl-jittarget.sycl_jit_apply_target_warning_flags()as the single place for sycl-jit warning flags (-Wconversion, optional-Werror, and host GCC-Wno-error=conversionon LLVM/Clang headers).sycl-jit,SYCLJITPasses, andSYCLJITPassesPluginto that helper (replacing duplicatedtarget_compile_optionsandSYCL_JIT_WARNING_FLAGS).