[Clang][SYCL] Introduce warn_drv_unsupported_option_for_target_host_only - #22411
Merged
Merged
Conversation
The diagnostic warn_drv_unsupported_option_for_target was extended with a %select to append "; only supported for host compilation" for SYCL's use case (commit 707093d), requiring a third argument at all call sites. 707093d's change now breaks test Driver/hip-sanitize-options.hip which only expects 2 args. Fix by splitting the diagnostic into two: - warn_drv_unsupported_option_for_target (2 args, same-as-upstream) - warn_drv_unsupported_option_for_target_host_only (2 args, SYCL-specific) Update SYCL.cpp to use the new variant; drop the stale << 0 third arg from SanitizerArgs.cpp and Clang.cpp. Now Clang.cpp part is the same as upstream. CMPLRLLVM-76199 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
mdtoguchi
approved these changes
Jun 24, 2026
wenju-he
added a commit
that referenced
this pull request
Jun 26, 2026
…nly (#22411) The diagnostic warn_drv_unsupported_option_for_target was extended with a %select to append "; only supported for host compilation" for SYCL's use case (commit 707093d), requiring a third argument at all call sites. 707093d's change now breaks test Driver/hip-sanitize-options.hip which only expects 2 args. Fix by splitting the diagnostic into two: - warn_drv_unsupported_option_for_target (2 args, same-as-upstream) - warn_drv_unsupported_option_for_target_host_only (2 args, SYCL-specific) Update SYCL.cpp to use the new variant; drop the stale << 0 third arg from SanitizerArgs.cpp and Clang.cpp. Now Clang.cpp part is the same as upstream. CMPLRLLVM-76199 Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
wenju-he
added a commit
that referenced
this pull request
Jun 28, 2026
…nly (#22411) The diagnostic warn_drv_unsupported_option_for_target was extended with a %select to append "; only supported for host compilation" for SYCL's use case (commit 707093d), requiring a third argument at all call sites. 707093d's change now breaks test Driver/hip-sanitize-options.hip which only expects 2 args. Fix by splitting the diagnostic into two: - warn_drv_unsupported_option_for_target (2 args, same-as-upstream) - warn_drv_unsupported_option_for_target_host_only (2 args, SYCL-specific) Update SYCL.cpp to use the new variant; drop the stale << 0 third arg from SanitizerArgs.cpp and Clang.cpp. Now Clang.cpp part is the same as upstream. CMPLRLLVM-76199 Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The diagnostic warn_drv_unsupported_option_for_target was extended with a %select to append "; only supported for host compilation" for SYCL's use case (commit 707093d), requiring a third argument at all call sites.
707093d's change now breaks test Driver/hip-sanitize-options.hip which only expects 2 args.
Fix by splitting the diagnostic into two:
Update SYCL.cpp to use the new variant; drop the stale << 0 third arg from SanitizerArgs.cpp and Clang.cpp. Now Clang.cpp part is the same as upstream.
CMPLRLLVM-76199