@ionic/react: attachProps should drop undefined - #31345
Open
ptmkenny wants to merge 1 commit into
Open
Conversation
|
@ptmkenny is attempting to deploy a commit to the Ionic Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #31344
What is the current behavior?
When a React component forwards an optional prop to an Ionic component and the caller
leaves it unset,
@ionic/reactwrites the string"undefined"into the corresponding DOMattribute.
renders:
There is no error and no warning. Consequences:
duplicate ids (invalid HTML), and
document.getElementById('undefined')resolves towhichever comes first.
idis not special. Any prop backed by a reflected DOM property behaves the same way:title={undefined}produces a tooltip that reads "undefined", andslot={undefined}places the element in a slot named
undefined, which moves it in the layout.undefinedis not cleared: the attribute isoverwritten with
"undefined"rather than removed.What is the new behavior?
Skip undefined values, and treat a prop that had a value and no longer does
as a removal, which is how React handles it.
Does this introduce a breaking change?
Other information
Prepared with Claude Opus. This seems to be @ionic/react specific, as
attachPropsis React-only.