Repository navigation
ci: bump reactivecircus/android-emulator-runner from 2.37.0 to 2.38.0 - #2933
Closed
dependabot[bot] wants to merge 1 commit into
Closed
dependabot[bot] wants to merge 1 commit into
dependabot[bot] wants to merge 1 commit into
Conversation
dependabot
Bot
added
dependencies
jaime-jmebot
approved these changes
Sep 16, 2026
jaime-jmebot
left a comment
jaime-jmebot
left a comment
Contributor
There was a problem hiding this comment.
Dependabot bump of reactivecircus/android-emulator-runner from v2.37.0 to v2.38.0.
- Single-line change in
.github/workflows/android-screenshot.yml; no other workflow references this action, so no other occurrence was left behind. - Tag pinning matches the existing convention in this repo (other actions use
@vX.Y.Z), so no pinning-policy inconsistency is introduced. - Upstream 2.38.0 only updates the bundled SDK build tools to 37.0.0; the workflow's
api-level: 35,avd-name,profile, andemulator-optionsinputs are unchanged by this release, and the AVD cache key (avd-35) is unaffected. - No further code or config changes required; CI will confirm the runner still provisions the emulator.
Member
|
/dependabot rebase |
Bumps [reactivecircus/android-emulator-runner](https://github.com/reactivecircus/android-emulator-runner) from 2.37.0 to 2.38.0. - [Release notes](https://github.com/reactivecircus/android-emulator-runner/releases) - [Changelog](https://github.com/ReactiveCircus/android-emulator-runner/blob/main/CHANGELOG.md) - [Commits](ReactiveCircus/android-emulator-runner@v2.37.0...v2.38.0) --- updated-dependencies: - dependency-name: reactivecircus/android-emulator-runner dependency-version: 2.38.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
force-pushed
the
dependabot/github_actions/reactivecircus/android-emulator-runner-2.38.0
branch
from
September 16, 2026 17:33
4a2a5e6 to
66e5895
Compare
jaime-jmebot
added a commit
to jaime-jmebot/jmonkeyengine
that referenced
this pull request
Sep 17, 2026
… 25.2.4, android-emulator-runner 2.38.0 Implements the four open Dependabot findings for jMonkeyEngine#2958, plus the minimum build fallout they cause. ## Dependency updates | Finding | File | Change | | --- | --- | --- | | jMonkeyEngine#2955 | `gradle/libs.versions.toml` | `org.junit:junit-bom` 5.13.4 → 6.1.3 | | jMonkeyEngine#2955 | `jme3-screenshot-tests-shared/build.gradle`, `jme3-screenshot-tests-desktop/build.gradle` | hardcoded `org.junit:junit-bom` / `useJUnitJupiter` 5.9.1 → 6.1.3 (all JUnit usages now resolve to one version) | | jMonkeyEngine#2956 | `gradle/libs.versions.toml` | `org.apache.groovy:groovy-test` 4.0.31 → 5.1.0 | | jMonkeyEngine#2957 | `jme3-nativeimage-plugin/build.gradle` | `org.graalvm.sdk:nativeimage` 25.0.3 → 25.2.4 (`org.graalvm.nativeimage:svm` deliberately left at 25.0.3, as in the Dependabot PR) | | jMonkeyEngine#2933 | `.github/workflows/android-screenshot.yml` | `reactivecircus/android-emulator-runner` v2.37.0 → v2.38.0 | ## Required fallout fixes **`jme3-core/src/test/groovy/com/jme3/app/state/AppStateManagerTest.groovy`** — migrated from the JUnit-3-based `groovy.test.GroovyTestCase` (removed in Groovy 5) to JUnit 5 Jupiter. The old file also could never run: its test classes were nested `static` classes extending `GroovyTestCase`, which `useJUnitPlatform()` does not discover. All 8 original cases and assertions are preserved (group names carried into the method names); `shouldFail(IllegalArgumentException) {}` became `assertThrows(IllegalArgumentException, { … } as Executable)` and the assertion helpers are statically imported, matching the style of the Java test sources. **`common.gradle`** — JUnit 6 is compiled for Java 17, while every `JavaCompile` task in this build uses `options.release = 8`, so javac rejects the JUnit 6 jars. `options.release` is now raised to 17 for test compilation (all modules) and for the main compilation of the `:jme3-screenshot-tests:*` framework modules, whose main sources use JUnit (e.g. `ScreenshotTest.java` imports `org.junit.jupiter.api.Assertions.fail`). The engine itself still targets Java 8. No other dependency was touched. ## Validation status (read before approving) Performed in the sandbox on a clean checkout of the patch: * `gradle/libs.versions.toml` parses; `junit-bom = …6.1.3`, `groovy-test = …5.1.0`. * `.github/workflows/android-screenshot.yml` parses as YAML; runner pinned at `@v2.38.0`. * version audit: no `junit-bom:5*`, `groovy-test:4*`, `nativeimage:25.0.3` (only `svm:25.0.3` remains), `emulator-runner@v2.37.0` or `5.9.1` anywhere in the touched files. * `AppStateManagerTest.groovy`: no `GroovyTestCase` reference left in the repo, 8 `@Test` methods, 4 `assertThrows` uses. * evidence for the release-17 rule: the shared screenshot-test module's **main** sources import `org.junit`. **Not performed here:** compiling and running the test suite. This sandbox has no route to `services.gradle.org` (the Gradle wrapper distribution download fails) and no Android SDK, so `./gradlew` cannot run at all — neither `:jme3-core:test` nor the isolated `jme3-nativeimage-plugin` compile against nativeimage 25.2.4 could be executed. Nothing in this description should be read as a passing build. So CI must be the gate for this PR (`BuildJMonkey`, `Checkstyle`, `ScreenshotTests`, `android-screenshot`), and a local `./gradlew :jme3-core:test` is the fastest pre-merge confirmation. Known residual risks to watch in CI: 1. `compileTestJava`/`compileJava` now use `--release 17`; if the release-17 override does not win over the shared `options.release = 8` block, javac will report "class file has wrong version 61.0" for the JUnit 6 jars — that is the exact symptom to look for. 2. `mockito-junit-jupiter` 5.23.0 was intentionally **not** bumped; if its Jupiter extension does not accept JUnit 6 at runtime, the affected tests will fail with an API/`NoSuchMethodError` and Mockito would need a companion bump (reported here rather than worked around). 3. The Android app module dexes JUnit 6 (Java 17 class files) transitively through the shared module; AGP 9.1 should accept that, but it can only be confirmed by the Android build.
11 tasks done
Member
|
/dependabot rebase |
Contributor
Author
|
Looks like reactivecircus/android-emulator-runner is up-to-date now, so this is no longer needed. |
dependabot
Bot
deleted the
dependabot/github_actions/reactivecircus/android-emulator-runner-2.38.0
branch
September 19, 2026 13:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps reactivecircus/android-emulator-runner from 2.37.0 to 2.38.0.
Release notes
Sourced from reactivecircus/android-emulator-runner's releases.
Changelog
Sourced from reactivecircus/android-emulator-runner's changelog.
Commits
a421e43Merge branch 'main' into release/v2cad3216Prepare for release 2.38.0.ed6254cRevert "AddminorApiLevelfor compile SDK. Test with API 37.0."8acdc11AddminorApiLevelfor compile SDK. Test with API 37.0.a917366Build tools 37.0.0 (#475)ae2c4d7Add FreeOrion to the list (#470)