Skip to content

Add bounds checking before indexing vecvecTempMemory#3751

Merged
ann0see merged 1 commit into
jamulussoftware:mainfrom
softins:fix-issue-3747-crash
Jun 24, 2026
Merged

Add bounds checking before indexing vecvecTempMemory#3751
ann0see merged 1 commit into
jamulussoftware:mainfrom
softins:fix-issue-3747-crash

Conversation

@softins

@softins softins commented Jun 24, 2026

Copy link
Copy Markdown
Member

Short description of changes

Bug fix to add bounds checking to buffer initialisation when changing size of the server jitter buffer.

Some of the added tests might not be strictly necessary or reached, but they guarantee the bounds are checked.

CHANGELOG: Server: fix occasional crash seen when clients < 3.6 change jitter buffer size.

Context: Fixes an issue?

Fixes #3747

This has been raised against main, and it should be merged there first. We should then raise a branch for 3.12.2, starting at release/3_12_1 (6953c57) and do a 3.12.2 release by cherry-picking the commit from main.

Does this change need documentation? What needs to be documented and how?

No, bug fix only

Status of this Pull Request

Ready and tested

What is missing until this pull request can be merged?

Review

Checklist

  • I've verified that this Pull Request follows the general code principles
  • I tested my code and it does what I want
  • My code follows the style guide
  • I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
  • I've filled all the content above

@softins softins added the bug Something isn't working label Jun 24, 2026
@github-project-automation github-project-automation Bot moved this to Triage in Tracking Jun 24, 2026

@ann0see ann0see left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this in. Thanks!

@github-project-automation github-project-automation Bot moved this from Triage to Waiting on Team in Tracking Jun 24, 2026
@ann0see ann0see merged commit 6e3da20 into jamulussoftware:main Jun 24, 2026
11 checks passed
@github-project-automation github-project-automation Bot moved this from Waiting on Team to Done in Tracking Jun 24, 2026
@ann0see ann0see added this to the Release 3.12.2 milestone Jun 24, 2026
@ann0see

ann0see commented Jun 24, 2026

Copy link
Copy Markdown
Member

Release tagged. I hope it's correct this way.

Android doesn't build - but that's very likely unrelated. We should retry later.

@softins softins deleted the fix-issue-3747-crash branch June 24, 2026 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

jamulus 3.12.1 headless crash with out-of-bounds vector access

3 participants