Add bounds checking before indexing vecvecTempMemory#3751
Merged
Conversation
pljones
approved these changes
Jun 24, 2026
Member
|
Release tagged. I hope it's correct this way. Android doesn't build - but that's very likely unrelated. We should retry later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description of changes
Bug fix to add bounds checking to buffer initialisation when changing size of the server jitter buffer.
Some of the added tests might not be strictly necessary or reached, but they guarantee the bounds are checked.
CHANGELOG: Server: fix occasional crash seen when clients < 3.6 change jitter buffer size.
Context: Fixes an issue?
Fixes #3747
This has been raised against
main, and it should be merged there first. We should then raise a branch for 3.12.2, starting atrelease/3_12_1(6953c57) and do a 3.12.2 release by cherry-picking the commit frommain.Does this change need documentation? What needs to be documented and how?
No, bug fix only
Status of this Pull Request
Ready and tested
What is missing until this pull request can be merged?
Review
Checklist