[codex] Fix Snowflake workspace login type#351
Draft
zajca wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
loginType: snowflake-person-keypair.loginType, preserving the Storage API default behavior.login_typeargument and only serializes it when set.snowflake-person-keypairis treated as Query Service compatible in workspace list/detail enrichment.Why
Snowflake sandbox/workspace creation was relying on the Storage API default login type. That default should only remain for BigQuery; Snowflake needs the person keypair login type for newly created workspaces.
Verification
env UV_CACHE_DIR=/tmp/uv-cache uv run pytest tests/test_workspace_service.py tests/test_client.pyenv UV_CACHE_DIR=/tmp/uv-cache uv run ruff check src/keboola_agent_cli/client.py src/keboola_agent_cli/constants.py src/keboola_agent_cli/services/workspace_service.py tests/test_client.py tests/test_workspace_service.py