Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#322 switched hash-array insertion (
arraywithkey) toObject.definePropertyfor every entry so that a parsed key of"__proto__"becomes an own property instead of replacing the prototype. That is much slower than plain assignment.This PR rejects
"__proto__"keys at parse time instead and uses plain assignment for all other keys. The generated code reads the key into a temp variable once:Behaviour change vs #322: parsing an entry whose key is
"__proto__"now throwsInvalid key: __proto__. Before, the entry was stored as an own property. The regression test from #322 now expects the throw.Benchmark
Parsing
uint32le("len").array("items", { length: "len", key: "id", type: uint32le("id").uint16le("v") })with 1000 entries, 20000 iterations after warmup, Node v26.8.2:About 8x faster.