Skip to content

Add bitcoind to eget_packages and update installation command - #46

Open
kenorb wants to merge 1 commit into
dev-nodejsfrom
dev-bitcoind
Open

Add bitcoind to eget_packages and update installation command#46
kenorb wants to merge 1 commit into
dev-nodejsfrom
dev-bitcoind

Conversation

@kenorb

@kenorb kenorb commented Jul 27, 2026

Copy link
Copy Markdown
Owner

Summary by Sourcery

New Features:

  • Add Bitcoin Core full-node installation through the eget package list, with configurable version and supported architecture selection.

@coderabbitai

coderabbitai Bot commented Jul 27, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 19c3b85e-d91d-4b73-ba79-9332e33c8dd3

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dev-bitcoind

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sourcery-ai

sourcery-ai Bot commented Jul 27, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

The PR integrates Bitcoin Core's bitcoind into the eget package installation flow, using architecture-specific upstream archives and a configurable bitcoin_version variable, while enabling it in the example package configuration.

File-Level Changes

Change Details Files
Add Bitcoin Core bitcoind as an optional eget-managed package with architecture-aware downloads.
  • Define the bitcoind download URL using the configured Bitcoin Core version.
  • Map supported eget architectures to Bitcoin Core archive names and extract only the bitcoind binary.
  • Register bitcoind in the example eget_packages list.
.ansible/playbooks/tasks/eget.yml
.ansible/variables-example.yml
Expose the Bitcoin Core version as a configurable Ansible variable.
  • Add bitcoin_version with a default example value of 31.1.
  • Use the variable when constructing the bitcoind download URL, falling back to 31.1 when unset.
.ansible/playbooks/tasks/eget.yml
.ansible/variables-example.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@github-actions

Copy link
Copy Markdown

⛔ Workflow Failures Detected

The following job errors and annotations were found:

  • Check / check / Link Checker at .github:126: Process completed with exit code 2.
  • Check / check / Link Checker at .github:125: Summary report available at: https://github.com/kenorb/dotfiles/actions/runs/30289834085#summary-90056611669
  • Check / check / Pre-commit at .github:96: Process completed with exit code 1.
  • Check / check / Pre-commit at .ansible/variables-example.yml:174: Line too long (125 > 120 characters)
  • Check / check / Pre-commit at .ansible/playbooks/tasks/eget.yml:118: Line too long (122 > 120 characters)
  • Check / check / Pre-commit at .ansible/playbooks/tasks/eget.yml:109: Line too long (131 > 120 characters)
  • Check / check / Pre-commit at .ansible/playbooks/tasks/eget.yml:88: Line too long (139 > 120 characters)
  • Check / check / Pre-commit at .ansible/playbooks/tasks/eget.yml:118: 118:121 [line-length] line too long (122 > 120 characters)
  • Check / check / Pre-commit at .ansible/playbooks/tasks/eget.yml:109: 109:121 [line-length] line too long (131 > 120 characters)
  • Check / check / Pre-commit at .ansible/playbooks/tasks/eget.yml:88: 88:121 [line-length] line too long (139 > 120 characters)
  • Check / check / Pre-commit at .ansible/variables-example.yml:174: 174:121 [line-length] line too long (125 > 120 characters)

🛠️ Run Links

@github-actions github-actions Bot added the check-error Workflow reported errors label Jul 27, 2026
@kenorb
kenorb marked this pull request as ready for review September 10, 2026 18:42

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've found 1 issue

Prompt for AI Agents
Please address the comments from this code review:

## Individual Comments

### Comment 1
<location path=".ansible/playbooks/tasks/eget.yml" line_range="89-92" />
<code_context>
+      bitcoind: >-
+        --file '*/bin/bitcoind' --to bitcoind
+        https://bitcoincore.org/bin/bitcoin-core-{{ bitcoin_version | default('31.1') }}/bitcoin-{{ bitcoin_version | default('31.1') }}-{{
+          'x86_64' if eget_arch == 'x86_64'
+          else 'aarch64' if eget_arch == 'arm64'
+          else 'arm'
+        }}-linux-gnu.tar.gz
       btop: "-a btop-{{ eget_plain_arch }}-unknown-linux-musl.tar.gz aristocratos/btop"
</code_context>
<issue_to_address>
**issue (bug_risk):** On 32-bit ARM hosts, the URL is built with the `arm-linux-gnu` suffix, but Bitcoin Core's ARM archive uses `arm-linux-gnueabihf.tar.gz`; `eget` therefore receives a nonexistent URL and bitcoind installation fails.

**Triggers:** When `ansible_facts['architecture']` contains `arm` but is not `x86_64` or `aarch64`.

**Suggested fix:** Map the 32-bit ARM case to `arm-linux-gnueabihf` rather than appending the generic `-linux-gnu` suffix.

```suggestion
          'x86_64-linux-gnu' if eget_arch == 'x86_64'
          else 'aarch64-linux-gnu' if eget_arch == 'arm64'
          else 'arm-linux-gnueabihf'
        }}.tar.gz
```
</issue_to_address>

Sourcery assessment

Needs a human reviewer. 1 finding to address first, and a merge can install and potentially run a new bitcoind binary from an external URL, and a bad version, archive, or architecture choice could leave behind software and downloaded node data after the configuration is reverted. The impact is bounded and repairable by removing the package/data or rerunning installation with the correct version.

Blocking findings: .ansible/playbooks/tasks/eget.yml:92


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

Comment on lines +89 to +92
'x86_64' if eget_arch == 'x86_64'
else 'aarch64' if eget_arch == 'arm64'
else 'arm'
}}-linux-gnu.tar.gz

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue (bug_risk): On 32-bit ARM hosts, the URL is built with the arm-linux-gnu suffix, but Bitcoin Core's ARM archive uses arm-linux-gnueabihf.tar.gz; eget therefore receives a nonexistent URL and bitcoind installation fails.

Triggers: When ansible_facts['architecture'] contains arm but is not x86_64 or aarch64.

Suggested fix: Map the 32-bit ARM case to arm-linux-gnueabihf rather than appending the generic -linux-gnu suffix.

Suggested change
'x86_64' if eget_arch == 'x86_64'
else 'aarch64' if eget_arch == 'arm64'
else 'arm'
}}-linux-gnu.tar.gz
'x86_64-linux-gnu' if eget_arch == 'x86_64'
else 'aarch64-linux-gnu' if eget_arch == 'arm64'
else 'arm-linux-gnueabihf'
}}.tar.gz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

check-error Workflow reported errors

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant