Repository navigation
Conversation
The health-check guidance suggests issuing the probe certificate from the Authenticated Origin Pulls CA. When several hosts trust that CA, a stolen probe key passes the client certificate check on all of them, so point those deployments at a private CA per host.
vishr
enabled auto-merge (squash)
November 8, 2026 16:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
The TLS guide told readers to issue the health-check probe certificate from their Authenticated Origin Pulls CA. When several hosts trust that CA, one stolen probe key passes the client certificate check on all of them.
The guide now recommends a private CA used only by that host, appended to that host's
FANOUT_TLS_CLIENT_CA_FILEbundle next to the Authenticated Origin Pulls CA. Reusing the Authenticated Origin Pulls CA is acceptable only when one host trusts it.Docs only. No behaviour change.
Verification
just site-buildpasses.just checkpasses.internal/server/clientca.goand the health-check code. Its one finding, a conflict with the paragraph above the caution, is fixed here.