-
Notifications
You must be signed in to change notification settings - Fork 20
test: wire safeTarget validation into fork-choice spec test harness #322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+56
−16
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
c114952
Wire safeTarget store checks in the fork choice test harness so that
pablodeymo 0d5b1e6
Skip test_safe_target_uses_merged_pools_at_interval_3 in the fork choice
pablodeymo a96c4dc
Merge branch 'main' into wire-safe-target-store-checks
pablodeymo 375b9bf
Merge branch 'main' into wire-safe-target-store-checks
MegaRedHand 9fb36c9
test: un-skip `test_safe_target_uses_merged_pools_at_interval_3`
MegaRedHand 338c36e
chore: bump leanSpec commit
MegaRedHand 558fa88
docs: remove stale comment
MegaRedHand File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
safeTargetRoot(direct-root) field for new schemaThe new leanSpec #680 schema is paired as
safeTargetSlot+safeTargetRootLabel. If a future fixture revision also ships a direct-root counterpart namedsafeTargetRoot(mirroring thelatestJustifiedRoot/latestFinalizedRootpattern rather than reusing the legacysafeTargetfield), serde will silently discard it and the validation block inforkchoice_spectests.rswill never fire. Consider addingsafeTargetRoot: Option<H256>now so the struct schema is symmetric withlatestJustified*/latestFinalized*, even if it stays dormant until fixtures use it.Prompt To Fix With AI