feat: add frontend as third app type for apps domain - #2072
Open
zhmushan wants to merge 8 commits into
Open
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe apps create and list shortcuts now accept ChangesFrontend app type support
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
Bot
added
the
size/M
🚀 PR Preview Install Guide🧰 CLI updatenpm i -g https://pkg.pr.new/larksuite/cli/@larksuite/cli@f8ca19356c6003fc593fdf086233b87692c705e9🧩 Skill updatenpx skills add larksuite/cli#feat/frontend-app-type -y -g |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2072 +/- ##
=======================================
Coverage 75.16% 75.16%
=======================================
Files 912 912
Lines 96451 96475 +24
=======================================
+ Hits 72495 72517 +22
- Misses 18380 18381 +1
- Partials 5576 5577 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
1 task
SKILL.md's routing table already covered frontend, but the per-command reference docs still enumerated only html/full_stack. Update create/list/get enum values, add a frontend local-dev section, and note frontend in the release-create entry so agents document the third app type consistently.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@skills/lark-apps/references/lark-apps-create.md`:
- Line 12: Update the app type documentation to state only that the accepted
values are lowercase html, frontend, and full_stack. Remove the claim that the
CLI lowercases or normalizes user input, while preserving the enum values and
validation guidance.
In `@skills/lark-apps/references/lark-apps-local-dev.md`:
- Line 3: Update the applicability statement so database debugging is explicitly
limited to full_stack apps, while frontend and html remain covered only for
local development and publishing. Preserve the existing app-type scope and
clarify the workflow wording without changing other documentation.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 81db2afe-ef89-4f7b-9689-9ec9c7480d7a
📒 Files selected for processing (5)
skills/lark-apps/references/lark-apps-create.mdskills/lark-apps/references/lark-apps-get.mdskills/lark-apps/references/lark-apps-list.mdskills/lark-apps/references/lark-apps-local-dev.mdskills/lark-apps/references/lark-apps-release-create.md
- create.md: state the app-type enum is matched exactly (lowercase), drop the incorrect claim that the CLI normalizes case - local-dev.md: scope database debugging to full_stack (frontend/html have no DB) and add the +release-get finished-status poll to the frontend flow
The E2E coverage table and two test comments still described the --app-type enum as html/full_stack after frontend was added. Update them to html/frontend/full_stack for consistency; assertions are unaffected (they match on substrings, not the full enum set).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
appsdomain previously exposed onlyhtmlandfull_stackas public app types. This PR addsfrontendas the third public--app-type, letting users create pure-frontend (vite-react) apps viaapps +create --app-type frontendand filter them viaapps +list --app-type frontend. The value passes through to the backend verbatim; the CLI stays production-facing and carries no internal app-type codenames.Changes
frontendto the--app-typeenum, hint, and Tips inshortcuts/apps/apps_create.go; add acceptance test inshortcuts/apps/apps_create_test.gofrontendto the--app-typefilter enum and description inshortcuts/apps/apps_list.gofrontendhandling inshortcuts/apps/apps_init.gocomments (zero-value scaffold policy; verbatim passthrough to the scaffolder, no client-side translation)FRONTENDreturn value in thequeryAppTypecomment inshortcuts/apps/apps_meta.goskills/lark-apps/SKILL.md: three-way boundary (full_stack = has backend/DB, html = static, frontend = JS-interactive default), add type-upgrade guidance, and extend the dev-link note to cover frontendTest Plan
tests/cli_e2e/apps, incl. enum-rejection cases)apps +create --app-type frontend --dry-runsends"app_type":"frontend";apps +create --app-type spais rejected withallowed: html, frontend, full_stackapps +create --app-type frontendthenapps +getround-tripsapp_type=frontendagainst the deployed backendRelated Issues
N/A
Summary by CodeRabbit
frontendas an acceptedapp_typefor+createand+list, including updated command examples and allowed-value help text.+create --app-type frontendworks and, in--dry-run, the request reflects"app_type": "frontend"(case-sensitive enum enforcement).frontend, including+release-getpolling behavior.