Repository navigation
feat(sync): reconcile variation attachments - #840
Merged
Merged
Conversation
ctawiah
added this pull request to stack #844
October 2, 2026 20:40
This was referenced Oct 2, 2026
ctawiah
force-pushed
the
ctawiah/sync-attachment-reconciliation
branch
from
October 2, 2026 20:43
f6859f6 to
2adc8c0
Compare
This was referenced Oct 2, 2026
ctawiah
marked this pull request as ready for review
October 7, 2026 14:56
ld-ahartmann
approved these changes
Oct 7, 2026
ctawiah
force-pushed
the
ctawiah/sync-attachment-reconciliation
branch
2 times, most recently
from
October 7, 2026 15:44
8a9a250 to
0cde3fe
Compare
ctawiah
force-pushed
the
ctawiah/sync-attachment-reconciliation
branch
from
October 7, 2026 23:45
0cde3fe to
c0fe431
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit c0fe431. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Context
This layer connects tool and skill attachments to the prompt sync lifecycle. A synchronized variation can now reference local tool and skill files, compare them with LaunchDarkly, and update both sides without treating version numbers as content changes.
What changes
A synchronized workspace now uses this layout:
Review focus
Verification
go test ./internal/sync/...go test ./cmd/syncgo test ./...git diff --checkRelated changes
Review the stack in this order:
Note
Overview
Adds tool and skill attachments to the prompt sync workflow so variations can reference shared
tools/*.jsonandskills/*.mdfiles under.launchdarkly/<project>/, compile them into sync payloads, and round-trip them with LaunchDarkly.Local workspace: Wrappers gain
tools/skillsrefs; compile hydrates attachment content, rejects symlinks on managed paths, and writes variations plus dependencies in one staged transaction (existing shared tool files are preserved;upserton tools is kept across server pulls). Bootstrap fetches attachment bodies from the API and records manifest fingerprints from compiled disk state, with rollback of only files created in that operation.Sync planning & execution: Variation create/update API payloads include attachment refs. Fingerprints hash canonical attachment content (not runtime version pins). The manifest tracks tool/skill baselines separately and prunes unreferenced entries on detach/sync. Prompt sync resolves each attachment once (create with local
upsert, version on change, then pin versions on the variation), blocks execution while any conflict remains, groups conflicts when multiple variations share a changed dependency, and can refresh stale server pins after pulling LaunchDarkly content locally.Reviewed by Cursor Bugbot for commit 5b3e174. Bugbot is set up for automated code reviews on this repo. Configure here.