[bjester]

Summary

• Updates _get_client_ip_for_server to be more tolerant of sandboxing by handling specific socket establishment errors separately from connection errors to retrieve the address
• Updates test utility get_free_tcp_port to be tolerant of failures using port 0 for automatic free port assignment
• Updates test test_consistent_0_5_instance_id to override environment variables since the test must assert that MORANGO_NODE_ID does not influence the resulting ID

Reviewer guidance

• Do tests run locally?
• Do tests pass when you ask an agent to run them, with network filtering using nono?

Necessary config for ports

  "network": {
    "allow_domain": [
      "127.0.0.1",
    ],
    "open_port": [
      3000,
      8000,
      8001,
      8080,
      8081,
      8888,
      10001,
      10002,
      10003
    ]
  }

AI usage

Claude and I debugged these issues within my sandboxed agent session using nono, while working on #410 . Most of the changes were clear to me, so I made them initially, then let Claude ensure that the changes were robust. Then had Claude handle the review feedback, which we should have caught earlier.

[rtibblesbot]

🟡 Waiting for changes

Outcome: skipped — no new commits since 871db23

Last updated: 2026-11-06 00:39 UTC

[rtibblesbot]

PR #411: the narrowed IP-probe fallback and explicit live-server ports look correct. CI is passing.

• suggestion: the two new fallback branches in _get_client_ip_for_server have no tests (inline).
• nitpick: get_free_tcp_port leaks a socket per failed bind (inline).

Next step: This is a low-risk change; it needs a light-touch code review by a human engineer.

---

Written by rtibblesbot, an LLM-based coding agent.

[rtibblesbot]

PR #411: both prior findings resolved. No new findings. CI still pending.

Prior-finding status

RESOLVED — morango/sync/syncsession.py:71 — no test covers _get_client_ip_for_server fallbacks
RESOLVED — tests/testapp/tests/helpers.py — failed bind leaks open socket

Next step: Needs a full code review by a human engineer.

• Confirm falling back to 127.0.0.1 in _get_client_ip_for_server when the probe is denied is acceptable for real sync sessions, not just sandboxed tests.

---

Written by rtibblesbot, an LLM-based coding agent.