Repository navigation
regression: cover rendering at screen edges - #12
Merged
Merged
Conversation
MrSmile
approved these changes
Oct 29, 2026
MrSmile
left a comment
MrSmile
left a comment
Member
There was a problem hiding this comment.
LGTM, but it's quite sparse list of cases (there's nothing on top for example).
I think it would be better to spawn off-screen objects in all 8 sides & corners per each image.
rcombs
force-pushed
the
codex/offscreen-culling-regression
branch
from
October 29, 2026 21:46
eebba15 to
95926af
Compare
Member
Author
|
Re-pushed with all-edge all-corners tests, and also some tests for text runs that start offscreen. |
astiob
approved these changes
Oct 30, 2026
astiob
left a comment
astiob
left a comment
Member
There was a problem hiding this comment.
I haven’t looked very closely tbh, but sounds good in principle, the pics look fine, and at least some of the descriptions certainly sound useful in particular.
MrSmile
approved these changes
Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During testing of libass/libass#874, I ran across a few misrenders caused by some bugs in the branch's bounding-box and blur padding calculations. It seems pretty reasonable to have test cases in here that cover those cases.