Skip to content

chore: replace or upgrade deprecated packages - #857

Merged
dennisvankekem merged 7 commits into
mainfrom
APL-2203
Oct 13, 2026
Merged

dennisvankekem merged 7 commits into
mainfrom
APL-2203

Conversation

@dennisvankekem

Copy link
Copy Markdown
Collaborator

Considerations

  • I have tested the changes in both light and dark mode.
  • I have considered the need for new unit tests.
  • I have tested the changes on a cluster.
  • I have included relevant documentation updates.
  • I have an approved Figma design or have reflected my changes in Figma
  • I have verified that the UI/UX is consistent in major browsers (e.g., Chrome, Firefox, Safari, Edge).
  • I have tested the changes for responsiveness in different screen resolutions.
  • I have tested expected error states and verified that the user is presented with informative error messages.
  • I have tested the feature with unusual or extreme inputs (e.g., very long strings, empty states, clicking a button multiple times quickly).

Copilot AI balanced review requested due to automatic review settings October 13, 2026 10:38

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Dependency compatibility and tooling configuration issues can break runtime validation, linting, and contributor workflows.

4 open findings
What changed in this PR

Upgrades Material UI to v6 and Notistack to v3, adapting components, themes, accessibility, and tests.

Changes:

  • Migrates Lab loading buttons to Material UI buttons.
  • Updates snackbar styling and Session click handling.
  • Adds theme, accessibility, and integration tests.
File Description
src/​utils/​snack.tsx Adapts snackbar APIs and selectors.
src/​utils/​snack.test.tsx Tests snackbar integration.
src/​theme/​overrides/​overrides.test.tsx Updates Select role assertion.
src/​theme/​overrides/​LoadingButton.ts Removes obsolete Lab override.
src/​theme/​overrides/​index.ts Removes LoadingButton registration.
src/​theme/​overrides/​Button.ts Adds loading-icon alignment.
src/​providers/​Session.tsx Migrates snackbar click props.
src/​pages/​workloads/​create-edit/​WorkloadsCreateEditPage.tsx Migrates loading button import.
src/​pages/​teams/​create-edit/​TeamsCreateEditPage.tsx Migrates loading button import.
src/​pages/​settings/​platform/​PlatformSettingsPage.tsx Migrates loading button import.
src/​pages/​services/​create-edit/​ServicesCreateEditPage.tsx Migrates loading button import.
src/​pages/​secrets/​team/​create-edit/​SecretCreateEditPage.tsx Migrates loading button import.
src/​pages/​secrets/​platform/​create-edit/​PlatformSecretCreateEditPage.tsx Migrates loading button import.
src/​pages/​network-policies/​create-edit/​NetworkPoliciesIngressCreateEditPage.tsx Migrates loading button import.
src/​pages/​network-policies/​create-edit/​NetworkPoliciesEgressCreateEditPage.tsx Migrates loading button import.
src/​pages/​code-repositories/​create-edit/​CodeRepositoriesCreateEditPage.tsx Migrates loading button import.
src/​pages/​catalogs/​team-overview/​WorkloadCatalogsOverviewPage.tsx Migrates loading button import.
src/​pages/​catalogs/​platform/​create-edit/​CatalogsCreateEditPage.tsx Migrates loading button import.
src/​pages/​builds/​create-edit/​BuildsCreateEditPage.tsx Migrates loading button import.
src/​components/​ThemeColorPresets.tsx Rebuilds palette-dependent overrides.
src/​components/​ThemeColorPresets.test.tsx Tests theme presets and modes.
src/​components/​SubmitButton.tsx Migrates button implementation and props.
src/​components/​ObjWizardModal.tsx Migrates loading button import.
src/​components/​modals/​ConfigureGitModal.tsx Migrates loading button import.
src/​components/​Header.tsx Labels header selectors accessibly.
src/​components/​Header.test.tsx Tests selector labels and switching.
src/​components/​DeleteDialog.tsx Migrates loading button import.
src/​components/​DeleteButton.tsx Migrates loading button import.
src/​components/​Button/​alignment.test.tsx Updates v6 style and loading tests.
package.json Upgrades UI and development dependencies.
.eslintrc.yml Updates TypeScript lint rules.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread .eslintrc.yml
Comment thread package.json
Comment thread package.json
Comment thread package.json
@dennisvankekem dennisvankekem changed the title Apl 2203 chore: replace or upgrade deprecated packages Oct 13, 2026

@CasLubbers CasLubbers left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on cluster. Console works ✅

@dennisvankekem
dennisvankekem merged commit 72454c6 into main Oct 13, 2026
7 of 8 checks passed
@dennisvankekem
dennisvankekem deleted the APL-2203 branch October 13, 2026 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants