Repository navigation
chore: replace or upgrade deprecated packages - #857
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Dependency compatibility and tooling configuration issues can break runtime validation, linting, and contributor workflows.
4 open findings
What changed in this PR
Upgrades Material UI to v6 and Notistack to v3, adapting components, themes, accessibility, and tests.
Changes:
- Migrates Lab loading buttons to Material UI buttons.
- Updates snackbar styling and Session click handling.
- Adds theme, accessibility, and integration tests.
| File | Description |
|---|---|
src/utils/snack.tsx |
Adapts snackbar APIs and selectors. |
src/utils/snack.test.tsx |
Tests snackbar integration. |
src/theme/overrides/overrides.test.tsx |
Updates Select role assertion. |
src/theme/overrides/LoadingButton.ts |
Removes obsolete Lab override. |
src/theme/overrides/index.ts |
Removes LoadingButton registration. |
src/theme/overrides/Button.ts |
Adds loading-icon alignment. |
src/providers/Session.tsx |
Migrates snackbar click props. |
src/pages/workloads/create-edit/WorkloadsCreateEditPage.tsx |
Migrates loading button import. |
src/pages/teams/create-edit/TeamsCreateEditPage.tsx |
Migrates loading button import. |
src/pages/settings/platform/PlatformSettingsPage.tsx |
Migrates loading button import. |
src/pages/services/create-edit/ServicesCreateEditPage.tsx |
Migrates loading button import. |
src/pages/secrets/team/create-edit/SecretCreateEditPage.tsx |
Migrates loading button import. |
src/pages/secrets/platform/create-edit/PlatformSecretCreateEditPage.tsx |
Migrates loading button import. |
src/pages/network-policies/create-edit/NetworkPoliciesIngressCreateEditPage.tsx |
Migrates loading button import. |
src/pages/network-policies/create-edit/NetworkPoliciesEgressCreateEditPage.tsx |
Migrates loading button import. |
src/pages/code-repositories/create-edit/CodeRepositoriesCreateEditPage.tsx |
Migrates loading button import. |
src/pages/catalogs/team-overview/WorkloadCatalogsOverviewPage.tsx |
Migrates loading button import. |
src/pages/catalogs/platform/create-edit/CatalogsCreateEditPage.tsx |
Migrates loading button import. |
src/pages/builds/create-edit/BuildsCreateEditPage.tsx |
Migrates loading button import. |
src/components/ThemeColorPresets.tsx |
Rebuilds palette-dependent overrides. |
src/components/ThemeColorPresets.test.tsx |
Tests theme presets and modes. |
src/components/SubmitButton.tsx |
Migrates button implementation and props. |
src/components/ObjWizardModal.tsx |
Migrates loading button import. |
src/components/modals/ConfigureGitModal.tsx |
Migrates loading button import. |
src/components/Header.tsx |
Labels header selectors accessibly. |
src/components/Header.test.tsx |
Tests selector labels and switching. |
src/components/DeleteDialog.tsx |
Migrates loading button import. |
src/components/DeleteButton.tsx |
Migrates loading button import. |
src/components/Button/alignment.test.tsx |
Updates v6 style and loading tests. |
package.json |
Upgrades UI and development dependencies. |
.eslintrc.yml |
Updates TypeScript lint rules. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
CasLubbers
approved these changes
Oct 13, 2026
CasLubbers
left a comment
Contributor
There was a problem hiding this comment.
Tested on cluster. Console works ✅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Considerations