Skip to content

TPT-3501 Support NodeBalancer lke_cluster field#689

Open
jbilskiAkam wants to merge 3 commits intolinode:proj/nb-front-end-ip-in-vpcfrom
jbilskiAkam:feature/TPT-3501-python-sdk-support-nodebalancer-lke_cluster-and-type-fields
Open

TPT-3501 Support NodeBalancer lke_cluster field#689
jbilskiAkam wants to merge 3 commits intolinode:proj/nb-front-end-ip-in-vpcfrom
jbilskiAkam:feature/TPT-3501-python-sdk-support-nodebalancer-lke_cluster-and-type-fields

Conversation

@jbilskiAkam
Copy link
Copy Markdown

📝 Description

This PR adds support for the new read-only field lke_cluster in the NodeBalancer struct.

✔️ How to Test

To run relevant unit tests use:

make test-unit

@jbilskiAkam jbilskiAkam requested a review from a team as a code owner April 27, 2026 13:51
@jbilskiAkam jbilskiAkam requested review from yec-akamai and removed request for a team April 27, 2026 13:51
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds client support and test coverage for the new read-only NodeBalancer field lke_cluster.

Changes:

  • Added lke_cluster as a Property(json_object=...) on NodeBalancer.
  • Introduced LKECluster as a JSONObject dataclass for decoding the nested object.
  • Updated fixtures and unit tests to validate both populated and null lke_cluster responses.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
linode_api4/objects/nodebalancer.py Adds lke_cluster property mapping to decode the nested cluster reference.
linode_api4/common.py Introduces LKECluster JSONObject schema used by NodeBalancer decoding.
test/fixtures/nodebalancers.json Adds lke_cluster (object and null) to list fixture payload.
test/fixtures/nodebalancers_123456.json Adds lke_cluster object to single NodeBalancer fixture payload.
test/unit/objects/nodebalancers_test.py Extends list/get tests to assert lke_cluster decoding; fixes a docstring typo.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread linode_api4/common.py Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants