Skip to content

ACLP: Cleanup entity related response fields from alert definition #690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
shkaruna wants to merge 7 commits into
base: dev
Choose a base branch
from
Draft

ACLP: Cleanup entity related response fields from alert definition #690

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
8c069d3
feat: add ACLP list entities method
shkaruna Mar 30, 2026
5ee602c
reorder scope and regions check
shkaruna Apr 8, 2026
d671e08
update alert definition object
shkaruna Apr 9, 2026
2162c5c
Merge branch 'dev' of https://github.com/linode/linode_api4-python in…
shkaruna Apr 9, 2026
94894f1
Cleanup entity related fields from alert definition
shkaruna Apr 9, 2026
334b1f4
Merge branch 'dev' of https://github.com/linode/linode_api4-python in…
shkaruna Apr 27, 2026
9767a0c
ref: add channel_ids property in alert definition
shkaruna Apr 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion linode_api4/objects/monitor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -433,7 +433,6 @@ class AlertDefinition(DerivedBase):
"severity": Property(mutable=True),
"type": Property(mutable=True),
"status": Property(mutable=True),
"has_more_resources": Property(), # Deprecated; use entities.has_more_resources.
"rule_criteria": Property(mutable=True, json_object=RuleCriteria),
"trigger_conditions": Property(
mutable=True, json_object=TriggerConditions
Expand All @@ -449,6 +448,7 @@ class AlertDefinition(DerivedBase):
"scope": Property(AlertScope),
"regions": Property(mutable=True),
"entities": Property(json_object=AlertEntities),
"channel_ids": Property(mutable=True),
}


Expand Down
2 changes: 0 additions & 2 deletions test/fixtures/monitor_alert-definitions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
"description": "A test alert for dbaas service",
"scope": "entity",
"regions": [],
"entity_ids": ["13217"],
"entities": {
"url": "/monitor/services/dbaas/alert-definitions/12345/entities",
"count": 1,
Expand All @@ -23,7 +22,6 @@
"url": "/monitor/alert-channels/10000"
}
],
"has_more_resources": false,
"rule_criteria": null,
"trigger_conditions": null,
"class": "alert",
Expand Down
4 changes: 0 additions & 4 deletions test/fixtures/monitor_services_dbaas_alert-definitions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,6 @@
"description": "A test alert for dbaas service",
"scope": "entity",
"regions": [],
"entity_ids": [
"13217"
],
"entities": {
"url": "/monitor/services/dbaas/alert-definitions/12345/entities",
"count": 1,
Expand All @@ -25,7 +22,6 @@
"url": "/monitor/alert-channels/10000"
}
],
"has_more_resources": false,
"rule_criteria": {
"rules": [
{
Expand Down
4 changes: 0 additions & 4 deletions test/fixtures/monitor_services_dbaas_alert-definitions_12345.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,6 @@
"description": "A test alert for dbaas service",
"scope": "entity",
"regions": [],
"entity_ids": [
"13217"
],
"entities": {
"url": "/monitor/services/dbaas/alert-definitions/12345/entities",
"count": 1,
Expand All @@ -23,7 +20,6 @@
"url": "/monitor/alert-channels/10000"
}
],
"has_more_resources": false,
"rule_criteria": {
"rules": [
{
Expand Down