Feat/clone and group by#704
Draft
shkaruna wants to merge 10 commits into
Draft
Conversation
Release v5.37.0
Release v5.39.0
Release v5.41.0
Release v5.42.0
Release v5.43.0
Release 5.44.0
| "trigger_occurrences": 3 | ||
| }, | ||
| "class": "alert", | ||
| "status": "active", |
There was a problem hiding this comment.
Can we update status field to have a valid aclp alert status , not a dummy one?
| "polling_interval_seconds": 60, | ||
| "trigger_occurrences": 3 | ||
| }, | ||
| "class": "alert", |
|
|
||
| channels = list(client.monitor.alert_channels()) | ||
| if not channels: | ||
| pytest.skip( |
There was a problem hiding this comment.
is it necessary to do this? ideally we should always use an account where channel exist. or always create a fresh channel as use it?
shkaruna
force-pushed
the
feat/clone_and_group_by
branch
from
21396ef to
b957929
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
What does this PR do and why is this change necessary?
✔️ How to Test
What are the steps to reproduce the issue or verify the changes?
How do I run the relevant unit/integration tests?