Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the recent-document list contains files on an unavailable network automount, opening an unrelated document can freeze Xreader. Closing the window also stops responding because
ev_window_setup_recent()callsgtk_recent_info_exists()on the UI thread. Afile://URI can point to an automounted network share, sogtk_recent_info_is_local()does not make this check safe.Remove the existence check when building the File menu's recent-document list. Keep filtering by application, sorting and limiting the entries as before. File access and errors are handled by the existing document-loading path when the user selects an entry.
This means missing or temporarily unavailable documents remain listed. That is consistent with the existing toolbar recent chooser, whose GTK
show-not-founddefault is true, and avoids filesystem I/O just to populate the menu.Related: #32. Reproduced with Xreader 4.6.5; the same check is present on current master (4.6.9).
Validation:
straceshowed repeatednewfstatat()calls on the UI thread, each taking approximately 6.2 seconds before returningENODEV.git diff --checkpasses.