Pass options param to useGridLayout through GridLayout component#1322
Open
lauraguerra1 wants to merge 1 commit intolivekit:mainfrom
Open
Pass options param to useGridLayout through GridLayout component#1322lauraguerra1 wants to merge 1 commit intolivekit:mainfrom
lauraguerra1 wants to merge 1 commit intolivekit:mainfrom
Conversation
|
@lauraguerra1 is attempting to deploy a commit to the LiveKit Team on Vercel. A member of the Team first needs to authorize it. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR exposes
useGridLayout's existinggridLayoutsoption through theGridLayoutcomponent.Consumers can now pass custom
GridLayoutDefinition[]values directly toGridLayoutwithout needing to useuseGridLayoutthemselves.Changes
gridLayouts?: GridLayoutDefinition[]prop toGridLayoutgridLayoutsfromGridLayoutintouseGridLayoutgridLayoutsis not providedWhy
useGridLayoutalready supports custom grid layout definitions, but that flexibility was not available through the higher-levelGridLayoutcomponent. This change closes that gap and makes layout customization available without dropping down to the hook layer.