Repository navigation
fix(analytics): hint that an empty session list searched only the last 24 hours - #1026
Merged
Merged
Conversation
JackNDwyer
approved these changes
Oct 10, 2026
Topherhindman
force-pushed
the
devx-800-cli-participant-sessions-events
branch
from
October 10, 2026 03:11
bcb53de to
ae6a1dd
Compare
Topherhindman
force-pushed
the
cli-session-list-default-window
branch
2 times, most recently
from
October 10, 2026 03:12
398c87a to
f0023a5
Compare
Topherhindman
force-pushed
the
devx-800-cli-participant-sessions-events
branch
2 times, most recently
from
October 10, 2026 03:48
2d0e47e to
9c1422c
Compare
Topherhindman
force-pushed
the
cli-session-list-default-window
branch
2 times, most recently
from
October 10, 2026 04:21
4715d07 to
a53aa18
Compare
Topherhindman
force-pushed
the
devx-800-cli-participant-sessions-events
branch
2 times, most recently
from
October 10, 2026 04:37
2759435 to
9eb6d33
Compare
Topherhindman
force-pushed
the
cli-session-list-default-window
branch
2 times, most recently
from
October 10, 2026 04:53
81920ac to
e631e6e
Compare
Topherhindman
force-pushed
the
devx-800-cli-participant-sessions-events
branch
from
October 10, 2026 04:53
9eb6d33 to
e200807
Compare
Topherhindman
force-pushed
the
cli-session-list-default-window
branch
from
October 10, 2026 05:03
e631e6e to
b65b9ed
Compare
Topherhindman
force-pushed
the
devx-800-cli-participant-sessions-events
branch
from
October 10, 2026 05:03
e200807 to
0a431da
Compare
Base automatically changed from
devx-800-cli-participant-sessions-events
to
main
October 10, 2026 05:15
Topherhindman
force-pushed
the
cli-session-list-default-window
branch
from
October 10, 2026 05:17
b65b9ed to
7888756
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lk analytics session listunder--experimental-authprinted only "No sessions found" whenever the last 24 hours were empty. With no--start, the Public API lists only the last 24 hours (itsTimeRangedefault), so a project whose latest session was two days ago looked like it had none.What changed
More results available — re-run with --cursor …):--startis set, when--cursoris (a cursor carries the window of the listing it came from), or with--json.--start's help is too: the flag is shared with the API-key endpoint, whose default window differs.Testing
TestSearchedDefaultWindowcovers no--start, a--start, and a cursor.go test ./cmd/lk/ ./pkg/public/...andgo vetpass.--experimental-api-url https://beta-api.staging.livekit.cloud), on a project whose last session was 2026-10-07:--startprints the two lines above;--start 2026-10-08prints onlyNo sessions found;--jsonprints{"items": []}with no hint.