Skip to content

fix(cloudagents): extend attributes to CreateAgent #945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
s-hamdananwar merged 2 commits into from
Aug 25, 2026
Merged

fix(cloudagents): extend attributes to CreateAgent #945

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dfbade6
fix(cloudagents): extend attributes to CreateAgent
s-hamdananwar Aug 24, 2026
debeac8
chore: pick up server-sdk-go with CreateAgent attributes
s-hamdananwar Aug 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions cmd/lk/agent.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -628,6 +628,11 @@ func createAgent(ctx context.Context, cmd *cli.Command) error {
return err
}

attrs, err := resolveDeployAttributes(ctx, cmd)
if err != nil {
return err
}

imageRef := cmd.String("image")
imageTar := cmd.String("image-tar")
// Prebuilt image: no local project layout is required; skip language/dockerfile/sdk checks.
Expand All @@ -651,10 +656,6 @@ func createAgent(ctx context.Context, cmd *cli.Command) error {
return err
}
out.Statusf("Created agent with ID [%s]", util.Accented(agentID))
attrs, err := resolveDeployAttributes(buildContext, cmd)
if err != nil {
return err
}
return deployPrebuiltImage(buildContext, agentID, imageRef, imageTar, attrs)
}

Expand Down Expand Up @@ -686,7 +687,7 @@ func createAgent(ctx context.Context, cmd *cli.Command) error {
regions := []string{region}

excludeFiles := []string{fmt.Sprintf("**/%s", config.LiveKitTOMLFile)}
resp, err := agentsClient.CreateAgent(buildContext, os.DirFS(workingDir), secrets, regions, excludeFiles, os.Stderr)
resp, err := agentsClient.CreateAgent(buildContext, os.DirFS(workingDir), secrets, regions, attrs, excludeFiles, os.Stderr)
if err != nil {
if errors.Is(err, context.DeadlineExceeded) {
return fmt.Errorf("build timed out possibly due to large image size")
Expand Down
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ require (
github.com/joho/godotenv v1.5.1
github.com/klauspost/compress v1.19.1
github.com/livekit/protocol v1.50.5-0.20260824151414-2122e1d08bc9
github.com/livekit/server-sdk-go/v2 v2.18.2-0.20260824093707-96a978c6d455
github.com/livekit/server-sdk-go/v2 v2.18.2-0.20260824201634-1f82cc396645
github.com/mattn/go-isatty v0.0.22
github.com/moby/moby/client v0.4.1
github.com/moby/patternmatcher v0.6.1
Expand Down
4 changes: 2 additions & 2 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -348,8 +348,8 @@ github.com/livekit/protocol v1.50.5-0.20260824151414-2122e1d08bc9 h1:miNG55TBZC+
github.com/livekit/protocol v1.50.5-0.20260824151414-2122e1d08bc9/go.mod h1:h4wP4IBPkT5aew7SZSGViHSmanKAiKWsHij/5YfL4BE=
github.com/livekit/psrpc v0.7.3 h1:bekuZt/ZQzg8+/M8G6G5jq7bvV9fAKdPHSOZeTwrIIc=
github.com/livekit/psrpc v0.7.3/go.mod h1:rAI+m2+/cb4x9RXhLRtUx5ZwdfjjXOl4zi46IjEetaw=
github.com/livekit/server-sdk-go/v2 v2.18.2-0.20260824093707-96a978c6d455 h1:VwmCRY/b6f4gWtJyCJejqWnBlUYeHb6MTh4LznGF6Q0=
github.com/livekit/server-sdk-go/v2 v2.18.2-0.20260824093707-96a978c6d455/go.mod h1:qkHEZCUjVLpBs2zIhDo7zbX5f1mehGAROkRkPNSyfpc=
github.com/livekit/server-sdk-go/v2 v2.18.2-0.20260824201634-1f82cc396645 h1:KGS5da8KCS1sg3PwNUaZMYB2gjn8HJVji8alF9UU7Ys=
github.com/livekit/server-sdk-go/v2 v2.18.2-0.20260824201634-1f82cc396645/go.mod h1:qkHEZCUjVLpBs2zIhDo7zbX5f1mehGAROkRkPNSyfpc=
github.com/lucasb-eyer/go-colorful v1.4.0 h1:UtrWVfLdarDgc44HcS7pYloGHJUjHV/4FwW4TvVgFr4=
github.com/lucasb-eyer/go-colorful v1.4.0/go.mod h1:R4dSotOR9KMtayYi1e77YzuveK+i7ruzyGqttikkLy0=
github.com/magefile/mage v1.17.2 h1:fyXVu1eadI8Ap1HCCNgEhJ5McIWiYhLR8uol64ZZc40=
Expand Down
Loading