fix(simulate): mark a cited tool output where it prints - #946
Merged
Conversation
A summary can cite a tool output, and the digit jump opened the job without marking it: outputs were skipped unless tool detail was on, and printed with no mark when it was. A cited output now prints regardless of the toggle and carries the mark, like a cited function call.
theomonnom
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The run summary can cite a tool output (
function_call_output) with a<ref>. Pressing that citation's digit opened the job but never marked the turn:renderChatTranscriptskipped tool outputs unless tool detail was toggled on, and when it did print them it passed an empty mark, so the reader saw either "the cited turn is not in this transcript" or an unmarked output.A cited output now prints whether or not tool detail is on, and carries the
◀ citedmark like a cited function call does. Uncited outputs keep hiding behind the toggle.Whether the stored history carries an id for tool outputs is up to the agent-service summarizer; livekit/agents-private#396 fixes that side. Runs summarized before it deploys still cite ids the history doesn't have and keep showing the "not in this transcript" line.
Verified with
go vetandgo test ./cmd/lk(system portaudio).