Filtering with non existing / declared field is ignored / skipped

[HugoPoi]

Bug or feature request

• Bug
• Feature request

Description of feature (or steps to reproduce if bug)

1. Insert 10 rows in a model/table
2. Model.find({where: { nonexistingfield: 'test' } })
3. Return 10 rows

https://github.com/strongloop/loopback-connector/blob/97d2aea8686a2c66070696a73d23be0a76d14b97/lib/sql.js#L1096-L1100

Expected result

Return 0 (Memory connector return 0 and MongoDB Connector too)
In case of SQL this should throw an error ?

Actual result (if bug)

Return all the documents/rows

Additional information (Node.js version, LoopBack version, etc)

Only affect SQL connectors using lib/sql.js

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[stale]

This issue has been closed due to continued inactivity. Thank you for your understanding. If you believe this to be in error, please contact one of the code owners, listed in the CODEOWNERS file at the top-level of this repository.

[HugoPoi]

@jannyHou @dhmlau @emonddr Is this fix ? I think no.

[bajtos]

This hasn't been fixed yet. I am afraid the fix is complicated, see the discussion in #132.

@HugoPoi would you like to look into this problem yourself and contribute a fix? Feel free to take over the code from #132.