DM-53494: Add ability to run submit processes as batch jobs. - #232
DM-53494: Add ability to run submit processes as batch jobs.#232MichelleGower wants to merge 4 commits into
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #232 +/- ##
==========================================
+ Coverage 90.51% 92.69% +2.18%
==========================================
Files 51 53 +2
Lines 5627 6351 +724
Branches 544 572 +28
==========================================
+ Hits 5093 5887 +794
+ Misses 436 365 -71
- Partials 98 99 +1 ☔ View full report in Codecov by Harness. |
f2d5b3e to
ded85ad
Compare
ded85ad to
1e795c8
Compare
2982c22 to
7261b98
Compare
0030b99 to
f2a719b
Compare
f2a719b to
5d72fb4
Compare
Note: Limited to same cluster with shared filesystems.
5d72fb4 to
16b698b
Compare
| sections with corresponding names similar to ``finalJob``. Currently the | ||
| logging-related command-line arguments aren't passed from ``bps batch-submit`` | ||
| to these jobs. Instead, one can set ``bpsPreCommandOpts``, which has the | ||
| same default as the payload job. |
There was a problem hiding this comment.
Unless I missed something, the new command this PR implements (bps batch-submit) appears out of nowhere. Please, either provide more context what this command is or rewrite this paragraph without mentioning it at all. For example.
Currently the logging-related command-line arguments aren't passed to these jobs.
| config_file : `str` | ||
| Name of the configuration file. | ||
| **kwargs : `~typing.Any` | ||
| **kwargs : `dict` [`str`, `~typing.Any`] |
There was a problem hiding this comment.
Instead of fixing the type specification, I'd remove it entirely. See the example in the LSST Dev Guide.
| Parameters | ||
| ---------- | ||
| config : `lsst.ctrl.bps.BpsConfig` | ||
| Configuration. |
There was a problem hiding this comment.
"Configuration." -> "BPS configuration."?
2 participants
Note: Limited to same cluster with shared filesystems.
Checklist
doc/changes