You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The min nitro requirement actually doesn't work well. It seems like the files under packages/react-native-quick-crypto/nitrogen/generated are generated with nitrogen v0.33.2, and they are incompatible with nitro v0.29.1/v0.31.2. The devDependencies/peerDependencies/generated code should use the same nitro version I guess.
#error NitroModules cannot be found! Are you sure you installed NitroModules properly?
#endif
but It is available after v0.32.0, which is higher than the min nitro requirement in peerDependencies mrousavy/nitro@c942637
Users who pinned nitro to a version under v0.32.0 can get the build errors when using RNQC, even if the min nitro requirement stated in RNQC's package.json is v0.29.1/v0.31.2
This PR is still valid because it doesn't make things worse and it is indeed required for #976. The compatibility issue is kinda out of the scope of this PR. I don't know if it's a rare compatibility issue of nitrogen or it is designed so.
wh201906
changed the title
Bump minimum requirement of nitro to 0.31.2 (peerDeps only)
chore(deps): Bump minimum requirement of nitro to 0.31.2 (peerDeps only)
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required for #976
I tested the new minimum nitro version with corresponding nitrogen/generated code and it works.