Update expected UI screenshots for the cloud blocking settings split [ignore_release] - #339
Open
snake14 wants to merge 5 commits into
Open
Update expected UI screenshots for the cloud blocking settings split [ignore_release]#339snake14 wants to merge 5 commits into
snake14 wants to merge 5 commits into
Conversation
…[ignore_release] The TrackingSpamPrevention section on the general settings page changed height in matomo-org/matomo#25208, which shifts where this card is captured by a pixel.
…king-mode # Conflicts: # tests/UI/expected-ui-screenshots/QueuedTrackingSettings_settings_page.png # tests/UI/expected-ui-screenshots/QueuedTrackingSettings_settings_page_sentinel.png
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The TrackingSpamPrevention section on the general settings page changed height in matomo-org/matomo#25208, which splits its single "block tracking requests from the cloud" tickbox into a three-way organisation blocking mode and a separate cloud IP range tickbox. This plugin's settings card sits below that section on the same page, so the point at which its screenshot is captured shifts by a pixel and the anti-aliasing follows. No behaviour of this plugin changes.
The image was taken from the core pull request's CI run rather than generated locally.
Issue No
PG-5445
Steps to Replicate the Issue
Checklist