Repository navigation
LangSet subjectField order; App def-list/disp-formula/disp-quote mappings - #67
Merged
Merged
Conversation
…ormula/disp-quote Built models serialize in declaration order, and the NISO STS langSet content model puts subjectField before the tig sequence — the mapping declared it last, so every built langSet with a subjectField was schema-invalid (sts-ruby#66). App's content model also allows def-list, disp-formula and disp-quote; add the attributes and mappings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #66.
TbxIsoTml::LangSet:subjectFieldmapping moved beforetig— declaration order drives built-model serialization, and the NISO STS content model requires subjectField first (every built langSet with a subjectField was schema-invalid).NisoSts::App: adds the missingdef-list/disp-formula/disp-quoteattributes and mappings (allowed by the app content model).Test plan