Skip to content

LangSet subjectField order; App def-list/disp-formula/disp-quote mappings - #67

Merged
ronaldtse merged 1 commit into
mainfrom
fix/langset-order-app-mappings
Nov 17, 2026
Merged

ronaldtse merged 1 commit into
mainfrom
fix/langset-order-app-mappings

Conversation

@ronaldtse

Copy link
Copy Markdown
Contributor

Summary

Fixes #66.

  • TbxIsoTml::LangSet: subjectField mapping moved before tig — declaration order drives built-model serialization, and the NISO STS content model requires subjectField first (every built langSet with a subjectField was schema-invalid).
  • NisoSts::App: adds the missing def-list / disp-formula / disp-quote attributes and mappings (allowed by the app content model).

Test plan

  • Full suite green (5964 examples)
  • Consumer check: metanorma-iso native STS emission on ISO 19135-2 loses its 21 subjectField-order findings with this gem

…ormula/disp-quote

Built models serialize in declaration order, and the NISO STS langSet
content model puts subjectField before the tig sequence — the mapping
declared it last, so every built langSet with a subjectField was
schema-invalid (sts-ruby#66). App's content model also allows def-list,
disp-formula and disp-quote; add the attributes and mappings.
@ronaldtse
ronaldtse merged commit c5bcb12 into main Nov 17, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

LangSet mapping order serializes subjectField after tig (invalid); NisoSts::App missing def-list/disp-formula/disp-quote mappings

1 participant