Update release issue template to handle latest release procedure by joaosaffran · Pull Request #8757 · microsoft/DirectXShaderCompiler

joaosaffran · 2026-08-10T19:48:19Z

This patch updates the Release issue template to also account for the SPIRV SDK release and to account for NVIDIA validating SPIRV instead of google.

Fix: microsoft/hlsl-specs#888

Copilot

Pull request overview

Updates the release issue template to reflect the latest SPIR-V release process.

Changes:

Adds final branch synchronization and SPIR-V submodule updates.
Replaces Google sign-off with NVIDIA sign-off.
Adds LunarG release notification.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Alex Sepkowski (alsepkow) · 2026-08-10T19:54:20Z


 - [ ] Tag final release and post binaries
 - [ ] Add the new compiler to Compiler Explorer
+- [ ] Email LunarG the release tag and update the release spreadsheet.


Does this still apply to all spot releases/releases? I think it will only apply to when we are doing a release alongside LunarG?

Yes, it only applies for when we are releasing alongside LunarG. However this issue doesn't seem to distinguish between different releases. For example, it doesn't specify what is part of a spot release or a full release.

I think that's because we weren't consistently creating issues for spot releases before. Maybe now is a good time to add the differentiation? Or maybe it's obvious enough when it doesn't apply

We should probably have a different issue for each. Or maybe a branch within the issue. I've done a number of point releases using the release issue and its always awkward

I like the idea of having a different issue for point releases, but I still think that those will have a bunch of branches within them, depending on where we release and what we are releasing.

We already have too many issue templates, I'm not keen on adding another one. I think instructions to "delete as appropriate" or maybe being able to list some as "point release only" or "major release only" would work.

Another tool we have is that we can put HTML comments or other instructions into the template - it's reasonable to expect the person creating the new release to have to edit / customize it a bit. We already expect them to fill in the dates, for example.

I've added some minor comments pointing Damyan Pepper (@damyanp) suggestions

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Suppressed comments (1)

.github/ISSUE_TEMPLATE/release.md:56

Use the official NuGet capitalization, consistent with the package name on line 39 and in README.md.

- [ ] Publish the new compiler Nuget package.

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Suppressed comments (5)

.github/ISSUE_TEMPLATE/release.md:11

Typo: change 'bellow' to 'below' in this comment.

<!-- Some of the steps bellow might not be required, delete them as appropriate -->

.github/ISSUE_TEMPLATE/release.md:25

Grammar fixes would make these instructions clearer: use 'doesn't exist' (not 'don't exist') and 'kept in sync' (not 'kept into sync').

<!-- This is only required if the release branch don't exist -->

.github/ISSUE_TEMPLATE/release.md:34

Grammar fixes would make these instructions clearer: use 'doesn't exist' (not 'don't exist') and 'kept in sync' (not 'kept into sync').

    - The release branch is kept into sync with main via regular fast-forward

.github/ISSUE_TEMPLATE/release.md:41

Brand capitalization: change 'github' to 'GitHub'.

    - [ ] Zip files for github release

.github/ISSUE_TEMPLATE/release.md:60

These checklist items mix end punctuation (some end with periods, others don’t). For consistency/readability in templates, standardize punctuation across the list (either all with periods or all without).

- [ ] Email LunarG the release tag and update the release spreadsheet.
- [ ] Publish the new compiler Nuget package.
- [ ] Tag final release and post binaries

Damyan Pepper (damyanp) · 2026-08-17T18:28:50Z

+- [ ] Final merge of `main` into the release branch
+- [ ] Update SPIRV-Headers and SPIRV-Tools submodules, in the release branch,
+      to target the commits specified by LunarG.
 - [ ] Internal branches and build pipelines configured
    - Verify that the engineering system can build:
    - [ ] Zip files for github release
    - [ ] NuGet package
    - [ ] VPack


Configuring the branches and build pipelines needs to happen before the final merge of main.

Suggested change

- [ ] Final merge of `main` into the release branch

- [ ] Update SPIRV-Headers and SPIRV-Tools submodules, in the release branch,

to target the commits specified by LunarG.

- [ ] Internal branches and build pipelines configured

- Verify that the engineering system can build:

- [ ] Zip files for github release

- [ ] NuGet package

- [ ] VPack

- [ ] Internal branches and build pipelines configured

- Verify that the engineering system can build:

- [ ] Zip files for github release

- [ ] NuGet package

- [ ] VPack

- [ ] Final merge of `main` into the release branch

- [ ] Update SPIRV-Headers and SPIRV-Tools submodules, in the release branch,

to target the commits specified by LunarG.

Co-authored-by: Damyan Pepper <damyanp@microsoft.com>

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Suppressed comments (1)

.github/ISSUE_TEMPLATE/release.md:11

Corrected spelling of 'bellow' to 'below' in the guidance comment.

<!-- Some of the steps bellow might not be required, delete them as appropriate -->

Damyan Pepper (damyanp) · 2026-08-17T18:33:50Z

Also please check copilot github "suppressed comments" under the various copilot review comments - these highlight various spelling and grammatical errors that would be good to fix.

Gregory Roth (pow2clk) · 2026-08-17T18:36:35Z

 - [ ] Add the new compiler to Compiler Explorer
+- [ ] Email LunarG the release tag and update the release spreadsheet.
+- [ ] Publish the new compiler Nuget package.
+- [ ] Tag final release and post binaries


If this is chronological, it seems the tagging should still be first even if posting the binaries to the release should be last.

Gregory Roth (pow2clk) · 2026-08-17T18:38:54Z

 ---

+
+<!-- Some of the steps bellow might not be required, delete them as appropriate -->


Even though it's a comment. This is pretty broad. If any step can be skipped I see how creating a new release branch might not be needed for a point release, are there others?

typo

Suggested change

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Suppressed comments (3)

.github/ISSUE_TEMPLATE/release.md:57

This change removes the Google testing sign-off entirely and does not preserve the previous indentation (it used to be a sub-item). If Google sign-off is still required, it should be retained (and either kept as a separate top-level checkbox alongside Microsoft/NVIDIA, or restored as a nested item consistently). If it’s intentionally removed, please adjust the surrounding section to avoid losing that requirement silently (e.g., replace with a generic 'Partner testing sign-offs' list).

## Quality Sign Off

- [ ] Microsoft Testing Sign-off (@damyanp)
- [ ] NVIDIA Testing Sign-off (@dnovillo / @pow2clk)

.github/ISSUE_TEMPLATE/release.md:47

This step depends on an external source of truth ('commits specified by LunarG') but doesn’t indicate where to find them. Consider adding a pointer (e.g., link to the specific LunarG guidance location, email alias, or a standard document / tag naming convention) so release owners can execute this reliably without institutional knowledge.

- [ ] Update SPIRV-Headers and SPIRV-Tools submodules, in the release branch,
      to target the commits specified by LunarG.

.github/ISSUE_TEMPLATE/release.md:65

The official brand casing is typically 'NuGet' rather than 'Nuget'. Consider changing 'Nuget' to 'NuGet' for consistency with earlier references in this template.

- [ ] Email LunarG the release tag and update the release spreadsheet.
- [ ] Publish the new compiler Nuget package.

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Suppressed comments (3)

.github/ISSUE_TEMPLATE/release.md:57

The diff removes the Google testing sign-off item but does not add a replacement for it; instead, it adds NVIDIA. If Google sign-off is still required, re-add it as its own checklist item (and keep indentation consistent with the other sign-offs). If it is intentionally no longer required, consider adding a short comment explaining the change to avoid process confusion.

## Quality Sign Off

- [ ] Microsoft Testing Sign-off (@damyanp)
- [ ] NVIDIA Testing Sign-off (@dnovillo / @pow2clk)

.github/ISSUE_TEMPLATE/release.md:47

This task depends on an external source of truth (“commits specified by LunarG”) but doesn’t indicate where to find those commits (email? doc? repo issue?). Add a direct link or a brief pointer (e.g., location in LunarG tracking issue / version file) so release owners can reliably execute the step.

- [ ] Update SPIRV-Headers and SPIRV-Tools submodules, in the release branch,
      to target the commits specified by LunarG.

.github/ISSUE_TEMPLATE/release.md:64

This step references a “release spreadsheet” without identifying it. Please include a link to the spreadsheet (or the internal doc location), and ideally the distribution list/contact address for LunarG, to make the template actionable for new release owners.

- [ ] Email LunarG the release tag and update the release spreadsheet.

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Suppressed comments (1)

.github/ISSUE_TEMPLATE/release.md:57

The diff removes the 'Google Testing Sign-off' line but does not add it back elsewhere; instead it adds an NVIDIA sign-off as a peer item. If the intent was to replace Google with NVIDIA, the indentation change should be deliberate and consistent; otherwise, re-add Google testing sign-off (or keep both) and ensure the list nesting/structure matches the intended workflow.

## Quality Sign Off

- [ ] Microsoft Testing Sign-off (@damyanp)
- [ ] NVIDIA Testing Sign-off (@dnovillo / @pow2clk)

update release issue template to handle latest release procedure

a8d62cd

Copilot AI balanced review requested due to automatic review settings August 10, 2026 19:48

github-project-automation Bot added this to HLSL Roadmap Aug 10, 2026

github-project-automation Bot moved this to New in HLSL Roadmap Aug 10, 2026

Copilot started reviewing on behalf of joaosaffran August 10, 2026 19:48 View session

Copilot AI reviewed Aug 10, 2026

View reviewed changes

Alex Sepkowski (alsepkow) reviewed Aug 10, 2026

View reviewed changes

joaosaffran requested review from Alex Sepkowski (alsepkow), Diego Novillo (dnovillo) and Gregory Roth (pow2clk) August 10, 2026 19:58

Update release.md

f5dd18f

Copilot AI review requested due to automatic review settings August 12, 2026 00:20

Copilot started reviewing on behalf of joaosaffran August 12, 2026 00:20 View session

Copilot AI reviewed Aug 12, 2026

View reviewed changes

Diego Novillo (dnovillo) approved these changes Aug 12, 2026

View reviewed changes

Adding comments

a8fec1e

Copilot AI review requested due to automatic review settings August 17, 2026 18:05

Copilot AI reviewed Aug 17, 2026

View reviewed changes

joaosaffran requested review from Ashley Coleman (V-FEXrt) and Damyan Pepper (damyanp) August 17, 2026 18:25

Damyan Pepper (damyanp) requested changes Aug 17, 2026

View reviewed changes

github-project-automation Bot moved this from New to In progress in HLSL Roadmap Aug 17, 2026

Update .github/ISSUE_TEMPLATE/release.md

40ff97d

Co-authored-by: Damyan Pepper <damyanp@microsoft.com>

Copilot AI review requested due to automatic review settings August 17, 2026 18:32

Copilot AI reviewed Aug 17, 2026

View reviewed changes

Gregory Roth (pow2clk) reviewed Aug 17, 2026

View reviewed changes

Damyan Pepper (damyanp) mentioned this pull request Aug 17, 2026

Add a code-review agent skill #8788

Open

Update release.md

9aeed77

Copilot AI review requested due to automatic review settings August 17, 2026 19:06

Copilot AI reviewed Aug 17, 2026

View reviewed changes

Fix NuGet typing

355e18a

joaosaffran requested review from Copilot, Damyan Pepper (damyanp) and Gregory Roth (pow2clk) August 17, 2026 19:22

Copilot AI reviewed Aug 17, 2026

View reviewed changes

Damyan Pepper (damyanp) approved these changes Aug 17, 2026

View reviewed changes

joaosaffran merged commit c1104ee into microsoft:main Aug 17, 2026
13 checks passed

github-project-automation Bot moved this from In progress to Done in HLSL Roadmap Aug 17, 2026

		---


		<!-- Some of the steps bellow might not be required, delete them as appropriate -->

	<!-- Some of the steps bellow might not be required, delete them as appropriate -->
	<!-- Some of the steps below might not be required, delete them as appropriate -->

Uh oh!

Conversation

joaosaffran commented Aug 10, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Alex Sepkowski (alsepkow) Aug 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Damyan Pepper (damyanp) commented Aug 17, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Alex Sepkowski (alsepkow) Aug 10, 2026 •

edited

Loading